Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SetChange and MapChange when there is new entries in SortedSet and SortedMap #888

Closed
mdii opened this issue Sep 25, 2019 · 4 comments
Closed

Comments

@mdii
Copy link
Contributor

@mdii mdii commented Sep 25, 2019

After upgrading to the latest version (5.7.5), we have noticed that when we compare two objects some changes are not detected anymore. This happens for properties of type SortedSet and SortedMap (and I guess also for NavigableMap and NavigableSet). It seems that this regression is introduced in 5.2.5.

Here is the test case.

The issue comes from the fact that MapType.map() always returns an instance of UnmodifiableMap. When the property type is SortedMap, NodePair.sanitize() returns an empty map. A similar issue occurs for SortedSet.

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Sep 25, 2019

Hi , thanks for reporting, if you can contribute a PR with the fix, please do.

mdii added a commit to mdii/javers that referenced this issue Sep 30, 2019
@mdii
Copy link
Contributor Author

@mdii mdii commented Sep 30, 2019

PR created

bartoszwalacik added a commit that referenced this issue Oct 3, 2019
bartoszwalacik added a commit that referenced this issue Oct 3, 2019
bartoszwalacik added a commit that referenced this issue Oct 3, 2019
bartoszwalacik added a commit that referenced this issue Oct 3, 2019
@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Oct 3, 2019

Fix released in 5.7.7, @mdii thanks for your valuable contribution

@mdii
Copy link
Contributor Author

@mdii mdii commented Oct 3, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants