Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JaversAuditableDelete work with id(s), e.g. deleteById(id) #921

Closed
IlyaNerd opened this issue Dec 6, 2019 · 3 comments
Closed

Allow JaversAuditableDelete work with id(s), e.g. deleteById(id) #921

IlyaNerd opened this issue Dec 6, 2019 · 3 comments
Labels
fixed new feature

Comments

@IlyaNerd
Copy link
Contributor

IlyaNerd commented Dec 6, 2019 •
edited
Loading

Currently we need to provide the entire entity to mark it as deleted in javers when using JaversAuditableDelete, would be nice to be able provide only id(s) for that. Probably same way as its done in JaversSpringDataAuditableRepositoryAspect

@JaversAuditableDelete void deleteById(id)
@bartoszwalacik
Copy link
Member

we are open for contributions

@bartoszwalacik bartoszwalacik added contribution wanted this feature is wanted but won't be implemented by core team due to limited resources good first issue new feature labels Dec 6, 2019
@IlyaNerd
Copy link
Contributor Author

IlyaNerd commented Dec 6, 2019

i know, just wanted the approve :)

bartoszwalacik added a commit that referenced this issue Dec 13, 2019
@bartoszwalacik
#921 style fixes
c0f5133
bartoszwalacik added a commit that referenced this issue Dec 13, 2019
@bartoszwalacik
#921 test fixes
d7c9f28
@bartoszwalacik bartoszwalacik added fixed - waiting to be released and removed contribution wanted this feature is wanted but won't be implemented by core team due to limited resources good first issue labels Dec 13, 2019
@bartoszwalacik
Copy link
Member

Released in 5.8.7, thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartoszwalacik @IlyaNerd