Skip to content

/ javers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JaversAuditableDelete work with id(s), e.g. deleteById(id) #921

Closed
IlyaNerd opened this issue Dec 6, 2019 · 3 comments
Closed

Allow JaversAuditableDelete work with id(s), e.g. deleteById(id) #921

IlyaNerd opened this issue Dec 6, 2019 · 3 comments
Labels
fixed new feature

Comments

@IlyaNerd
Copy link
Contributor

@IlyaNerd IlyaNerd commented Dec 6, 2019 •
edited

Currently we need to provide the entire entity to mark it as deleted in javers when using JaversAuditableDelete, would be nice to be able provide only id(s) for that. Probably same way as its done in JaversSpringDataAuditableRepositoryAspect

@JaversAuditableDelete void deleteById(id)
@bartoszwalacik

This comment has been minimized.

Sign in to view
Copy link
Member

@bartoszwalacik bartoszwalacik commented Dec 6, 2019

we are open for contributions
@IlyaNerd

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@IlyaNerd IlyaNerd commented Dec 6, 2019

i know, just wanted the approve :)
IlyaNerd added a commit to IlyaNerd/javers that referenced this issue Dec 9, 2019
@IlyaNerd
javers#921: Allow JaversAuditableDelete work with id
b7faf6d
IlyaNerd added a commit to IlyaNerd/javers that referenced this issue Dec 11, 2019
@IlyaNerd
javers#921: extract method
1d0d293
bartoszwalacik added a commit that referenced this issue Dec 13, 2019
@bartoszwalacik
#921 style fixes
Loading status checks…
c0f5133
bartoszwalacik added a commit that referenced this issue Dec 13, 2019
@bartoszwalacik
#921 test fixes
Loading status checks…
d7c9f28
@bartoszwalacik

This comment has been minimized.

Sign in to view
Copy link
Member

@bartoszwalacik bartoszwalacik commented Dec 13, 2019

Released in 5.8.7, thanks for your contribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed new feature
Projects
None yet
Milestone
No milestone
2 participants
@IlyaNerd @bartoszwalacik
You can’t perform that action at this time.