Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove guava strong dep on javers-core #951

Closed
Dufgui opened this issue Mar 30, 2020 · 2 comments
Closed

Remove guava strong dep on javers-core #951

Dufgui opened this issue Mar 30, 2020 · 2 comments
Labels
fixed

Comments

@Dufgui
Copy link
Contributor

Dufgui commented Mar 30, 2020

Gradle optional is sadly not optional on maven.
https://blog.gradle.org/optional-dependencies

I propose to use gradle feature variant, to put gradle as maven optional
@bartoszwalacik
Copy link
Member

bartoszwalacik commented Mar 30, 2020 •
edited
Loading

makes sense, yoda should be <optional>true</optional> in maven pom

bartoszwalacik added a commit that referenced this issue Mar 30, 2020
@bartoszwalacik
#951 optional removed
0aeb1e0
bartoszwalacik added a commit that referenced this issue Mar 30, 2020
@bartoszwalacik
#951 test fixes
fcc6a97
@bartoszwalacik
Copy link
Member

fixed in 5.8.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dufgui @bartoszwalacik