Problem with fetching snapshot by commit id (from version 5.6.1) when using MongoDB

[patpro1]

Update from version 5.6.0 to 5.6.1 contains change in this line in MongoRepository.java (

javers/javers-persistence-mongo/src/main/java/org/javers/repository/mongo/MongoRepository.java

Line 282 in a72718a

.map(CommitId::valueAsNumber).collect(Collectors.toSet()));

):

.map(c -> c.valueAsNumber().doubleValue()).collect(Collectors.toSet()));

was changed to:

.map(CommitId::valueAsNumber).collect(Collectors.toSet()));

After that change when snapshot has commit id with minor version different than 0 (e.g. 372136.02) this snapshot is not fetched from repository by commit id - problem is in passing BigDecimal value to query instead of double value (with double value snapshot is returned without problems - checked by debugging on line

javers/javers-persistence-mongo/src/main/java/org/javers/repository/mongo/MongoRepository.java

Line 256 in a72718a

if (coreConfiguration.getCommitIdGenerator() == CommitIdGenerator.SYNCHRONIZED_SEQUENCE) {

)

I've added screens from debug between two version to explain the problem:

VERSION 5.6.0

VERSION 5.6.1

[bartoszwalacik]

@patpro1 don't paste your print-screens , provide a runnable test case as stated in Guidelines for Bug Reporting Guidelines for Bug Reporting

https://github.com/javers/javers/blob/master/CONTRIBUTING.md#guidelines-for-bug-reporting

[bartoszwalacik]

Reopen if you want to contribute a PR or if you come up with a failing test case

[patpro1]

@bartoszwalacik I've pushed failing test to my fork:

patpro1@4ea9eac

I hope it's enough?

[bartoszwalacik]

fixed in 5.10.4