-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Enable schema management check via config for JaversMongoRepositories #1261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add this new property to Spring config, see JaversSqlAutoConfigurationDefaultPropsTest.groovy
…s) configurable via Spring
@bartoszwalacik Thanks for reviewing and sharing comments. Make property schemaManagementEnabled(for MongoRepositories) configurable via Spring Make snapshotCollectionName, headCollectionName (for MongoRepositories) configurable via Spring |
Hey @bartoszwalacik , Did you have any chance to look at PR ? |
@@ -44,6 +44,9 @@ class JaversMongoStarterDefaultsTest extends BaseSpecification{ | |||
javersProperties.objectAccessHook == "org.javers.spring.mongodb.DBRefUnproxyObjectAccessHook" | |||
!javersProperties.mongodb | |||
javersProperties.snapshotsCacheSize == 5000 | |||
javersProperties.schemaManagementEnabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding ale these two missing props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
need to push it through CI now |
@bartoszwalacik , Because my current project which requires above feature was using java 11 and < Spring 3.0.0. |
@egasimov ok, 6.10.0 is published to the Central |
merged from here #1264 |
This PR intended to resolve Feature: Enable schema management check via config for JaversMongoRepositories #1260