Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable schema management check via config for JaversMongoRepositories #1261

Closed
wants to merge 3 commits into from

Conversation

egasimov
Copy link
Contributor

@egasimov egasimov commented Feb 2, 2023

Copy link
Member

@bartoszwalacik bartoszwalacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add this new property to Spring config, see JaversSqlAutoConfigurationDefaultPropsTest.groovy

@egasimov
Copy link
Contributor Author

egasimov commented Feb 6, 2023

@bartoszwalacik Thanks for reviewing and sharing comments.
I made following changes and would like you re-review my PR

Make property schemaManagementEnabled(for MongoRepositories) configurable via Spring

Make snapshotCollectionName, headCollectionName (for MongoRepositories) configurable via Spring

@egasimov
Copy link
Contributor Author

Hey @bartoszwalacik , Did you have any chance to look at PR ?

@@ -44,6 +44,9 @@ class JaversMongoStarterDefaultsTest extends BaseSpecification{
javersProperties.objectAccessHook == "org.javers.spring.mongodb.DBRefUnproxyObjectAccessHook"
!javersProperties.mongodb
javersProperties.snapshotsCacheSize == 5000
javersProperties.schemaManagementEnabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding ale these two missing props

Copy link
Member

@bartoszwalacik bartoszwalacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoszwalacik
Copy link
Member

bartoszwalacik commented Feb 14, 2023

need to push it through CI now

@egasimov
Copy link
Contributor Author

@bartoszwalacik ,
Could you please consider these changes as 6.9.2, rather than 7.. ?

Because my current project which requires above feature was using java 11 and < Spring 3.0.0.

@bartoszwalacik
Copy link
Member

@egasimov ok, 6.10.0 is published to the Central

@bartoszwalacik
Copy link
Member

merged from here #1264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enable schema management check via config for JaversMongoRepositories
2 participants