Skip to content

Feature: Enable schema management check via config for JaversMongoRepositories#1261

Closed
egasimov wants to merge 3 commits into
javers:masterfrom
egasimov:feature/issue-1260
Closed

Feature: Enable schema management check via config for JaversMongoRepositories#1261
egasimov wants to merge 3 commits into
javers:masterfrom
egasimov:feature/issue-1260

Conversation

@egasimov

@egasimov egasimov commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

@bartoszwalacik bartoszwalacik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add this new property to Spring config, see JaversSqlAutoConfigurationDefaultPropsTest.groovy

@egasimov

egasimov commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

@bartoszwalacik Thanks for reviewing and sharing comments.
I made following changes and would like you re-review my PR

Make property schemaManagementEnabled(for MongoRepositories) configurable via Spring

Make snapshotCollectionName, headCollectionName (for MongoRepositories) configurable via Spring

@egasimov

Copy link
Copy Markdown
Contributor Author

Hey @bartoszwalacik , Did you have any chance to look at PR ?

javersProperties.objectAccessHook == "org.javers.spring.mongodb.DBRefUnproxyObjectAccessHook"
!javersProperties.mongodb
javersProperties.snapshotsCacheSize == 5000
javersProperties.schemaManagementEnabled

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding ale these two missing props

@bartoszwalacik bartoszwalacik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoszwalacik

bartoszwalacik commented Feb 14, 2023

Copy link
Copy Markdown
Member

need to push it through CI now

@egasimov

Copy link
Copy Markdown
Contributor Author

@bartoszwalacik ,
Could you please consider these changes as 6.9.2, rather than 7.. ?

Because my current project which requires above feature was using java 11 and < Spring 3.0.0.

@bartoszwalacik

Copy link
Copy Markdown
Member

@egasimov ok, 6.10.0 is published to the Central

@bartoszwalacik

Copy link
Copy Markdown
Member

merged from here #1264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Enable schema management check via config for JaversMongoRepositories

2 participants