Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
bartoszwalacik
reviewed
Aug 13, 2015
| @@ -24,7 +25,7 @@ | ||
| * | ||
| * @author bartosz walacik | ||
| */ | ||
| public class Diff { | ||
| public class Diff implements Serializable { |
This comment has been minimized.
This comment has been minimized.
bartoszwalacik
Aug 13, 2015
Member
thanks for contributing to JaVers,
what about Diff components? Change, Atomic, etc. Think we need a simple test which proofs that Diff serialization works.
You could add it to JaversDiffE2ETest
This comment has been minimized.
This comment has been minimized.
xeraa
commented
Oct 29, 2015
|
Any update on this? I'm also having issues since Diff isn't serializable |
This comment has been minimized.
This comment has been minimized.
|
@xeraa, as you see, @klearchos have created this Pull Request but he have abandoned the work ... |
bartoszwalacik
added
enhancement
labels
Oct 30, 2015
This comment has been minimized.
This comment has been minimized.
|
I polished it a bit in #269 |
pszymczyk
merged commit cd95162
into
javers:master
Dec 15, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
klearchos commentedAug 12, 2015
… it inside a DTO object that already implements Serializable.