Diff should implement Serializable otherwise I am not able to include… #188
Conversation
… it inside a DTO object that already implements Serializable.
| @@ -24,7 +25,7 @@ | |||
| * | |||
| * @author bartosz walacik | |||
| */ | |||
| public class Diff { | |||
| public class Diff implements Serializable { | |||
bartoszwalacik
Aug 13, 2015
Member
thanks for contributing to JaVers,
what about Diff components? Change, Atomic, etc. Think we need a simple test which proofs that Diff serialization works.
You could add it to JaversDiffE2ETest
thanks for contributing to JaVers,
what about Diff components? Change, Atomic, etc. Think we need a simple test which proofs that Diff serialization works.
You could add it to JaversDiffE2ETest
|
Any update on this? I'm also having issues since Diff isn't serializable |
|
@xeraa, as you see, @klearchos have created this Pull Request but he have abandoned the work ... |
|
I polished it a bit in #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
… it inside a DTO object that already implements Serializable.