New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff should implement Serializable otherwise I am not able to include… #188

Merged
merged 2 commits into from Dec 15, 2015

Conversation

Projects
None yet
4 participants
@klearchos
Contributor

klearchos commented Aug 12, 2015

… it inside a DTO object that already implements Serializable.

Diff should implement Serializable otherwise I am not able to include…
… it inside a DTO object that already implements Serializable.
@@ -24,7 +25,7 @@
*
* @author bartosz walacik
*/
public class Diff {
public class Diff implements Serializable {

This comment has been minimized.

@bartoszwalacik

bartoszwalacik Aug 13, 2015

Member

thanks for contributing to JaVers,
what about Diff components? Change, Atomic, etc. Think we need a simple test which proofs that Diff serialization works.
You could add it to JaversDiffE2ETest

@xeraa

This comment has been minimized.

xeraa commented Oct 29, 2015

Any update on this? I'm also having issues since Diff isn't serializable

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Oct 30, 2015

@xeraa, as you see, @klearchos have created this Pull Request but he have abandoned the work ...
you could continue this PR if you want, it's really easy.
Just add serializable for few classes and write an integration test

@pszymczyk

This comment has been minimized.

Member

pszymczyk commented Dec 12, 2015

I polished it a bit in #269

@pszymczyk pszymczyk merged commit cd95162 into javers:master Dec 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment