Skip to content

Diff should implement Serializable otherwise I am not able to include… - #188

Merged
pszymczyk merged 2 commits into
javers:masterfrom
klearchos:master
Dec 15, 2015
Merged

pszymczyk merged 2 commits into
javers:masterfrom
klearchos:master

Conversation

@klearchos

Copy link
Copy Markdown
Contributor

… it inside a DTO object that already implements Serializable.

… it inside a DTO object that already implements Serializable.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing to JaVers,
what about Diff components? Change, Atomic, etc. Think we need a simple test which proofs that Diff serialization works.
You could add it to JaversDiffE2ETest

@xeraa

xeraa commented Oct 29, 2015

Copy link
Copy Markdown

Any update on this? I'm also having issues since Diff isn't serializable

@bartoszwalacik

Copy link
Copy Markdown
Member

@xeraa, as you see, @klearchos have created this Pull Request but he have abandoned the work ...
you could continue this PR if you want, it's really easy.
Just add serializable for few classes and write an integration test

@pszymczyk

Copy link
Copy Markdown
Contributor

I polished it a bit in #269

@pszymczyk
pszymczyk merged commit cd95162 into javers:master Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants