New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ConditionalOnMissingBean on javers(connectionProvider) for Mongo and Sql #430

Merged
merged 3 commits into from Sep 8, 2016

Conversation

Projects
None yet
2 participants
@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Sep 8, 2016

@abibell I thought that this PR is about adding @ConditionalOnMissingBean to javers starters configuration. Then you could replace default javers bean with your javers bean with your configuration (scanTypeName()).
We didnt talked abould implementing scanTypeNames(). This is another issue - #263
And I think that javers should use some dedicated lib for classpath scanning.

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Sep 8, 2016

The first commit in this PR is OK, the second is not OK. I will merge if you remove the second commit. I think, the first one is enough to solve your issue

Revert "Added scanTypeNames()"
This reverts commit e9d18d4.
@abibell

This comment has been minimized.

Contributor

abibell commented Sep 8, 2016

Oops, 2nd commit wasn't meant to come into PR. Try it now.

With regards to second issue, what would library do you have in mind to use, is it worth it? Do you see introducing the classpath scanning library can be a separate issue to getting scanTypeNames(package)?

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Sep 8, 2016

yes, there is a separate issue for that - #263
Some research is needed, the ann scanning lib should be small (no dependencies) and fast

@bartoszwalacik bartoszwalacik merged commit 307be92 into javers:master Sep 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Sep 9, 2016

released in 2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment