Skip to content

Conversation

@abibell
Copy link
Contributor

@abibell abibell commented Sep 7, 2016

@bartoszwalacik
Copy link
Member

@abibell I thought that this PR is about adding @ConditionalOnMissingBean to javers starters configuration. Then you could replace default javers bean with your javers bean with your configuration (scanTypeName()).
We didnt talked abould implementing scanTypeNames(). This is another issue - #263
And I think that javers should use some dedicated lib for classpath scanning.

@bartoszwalacik
Copy link
Member

The first commit in this PR is OK, the second is not OK. I will merge if you remove the second commit. I think, the first one is enough to solve your issue

@abibell
Copy link
Contributor Author

abibell commented Sep 8, 2016

Oops, 2nd commit wasn't meant to come into PR. Try it now.

With regards to second issue, what would library do you have in mind to use, is it worth it? Do you see introducing the classpath scanning library can be a separate issue to getting scanTypeNames(package)?

@bartoszwalacik
Copy link
Member

yes, there is a separate issue for that - #263
Some research is needed, the ann scanning lib should be small (no dependencies) and fast

@bartoszwalacik bartoszwalacik merged commit 307be92 into javers:master Sep 8, 2016
@bartoszwalacik
Copy link
Member

released in 2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants