Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

448 Add @IgnoreDeclaredProperties annotation #452

Merged
merged 1 commit into from Nov 6, 2016

Conversation

ianagius
Copy link
Contributor

Add @IgnoreDeclaredProperties to classes to ignore all their properties.
If a class is annotated with @IgnoreDeclaredProperties and is part of an audited hierarchy, only the properties of the class are ignored, and JaVers will still track any other properties in the class hierarchy.
By contrast, if a class is annotated with @DiffIgnore JaVers will ignore all instances of that class.

@@ -20,14 +21,22 @@ public FieldBasedPropertyScanner(AnnotationNamesProvider annotationNamesProvider

@Override
public PropertyScan scan(Class<?> managedClass) {
final IgnoreDeclaredProperties ignoreDeclaredPropertiesAnnotation = managedClass.getAnnotation(IgnoreDeclaredProperties.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annotations scanning should be done in ClassScan. I'll fix it

@bartoszwalacik
Copy link
Member

bartoszwalacik commented Nov 5, 2016

your impl is wrong, all properties are ignored. Only declared properties should be ignored when new ann is present.
moved this thread to #453 to fix it

@bartoszwalacik bartoszwalacik merged commit 62c7a8a into javers:master Nov 6, 2016
@ianagius ianagius deleted the 448 branch November 14, 2016 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants