New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ianagius 448 #453
Ianagius 448 #453
Conversation
boolean hasTransientAnn = field.hasAnyAnnotation(annotationNamesProvider.getTransientAliases()); | ||
boolean hasShallowReferenceAnn = field.hasAnyAnnotation(annotationNamesProvider.getShallowReferenceAliases()); | ||
propertyList.add(new Property(field, hasTransientAnn, hasShallowReferenceAnn)); | ||
if (ignoreDeclaredPropertiesAnnotation != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong, it means that when @IgnoreDeclaredProperties
is present -- all properties will be ignored
abstract class PropertyScanner { | ||
abstract public PropertyScan scan(Class<?> managedClass, boolean ignoreDeclaredProperties); | ||
|
||
public PropertyScan scan(Class<?> managedClass, ClassAnnotationsScan classScan) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if PropertyScanner should be aware of ClassAnnotationsScan. Is it not an unnecessary coupling? The only information needed here is whether declared properties should be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will fix it
No description provided.