New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox adds an extra line. #5

Closed
rgfx opened this Issue Sep 16, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@rgfx

rgfx commented Sep 16, 2014

You have to add overflow-x: hidden; to the textarea.

@javierjulio

This comment has been minimized.

Owner

javierjulio commented Sep 16, 2014

@rgfx thanks for the suggestion! I was eager to try it out but I'm on the latest Firefox now 32.0.1 and I can't replicate the bug I was encountering. I commented out the code I had and Firefox is behaving just as I want it. Matches WebKit. What version of Firefox were you on that you were able to come up with the solution?

@puritania

This comment has been minimized.

puritania commented Nov 13, 2014

@javierjulio thanks for plugin.
FF problem with extra line:
0a81d583c5
FF 33.1 Win7x64

@javierjulio

This comment has been minimized.

Owner

javierjulio commented Nov 13, 2014

I thought I had resolved that but I tested on Firefox on Mac which had that same issue. Noticed it was not appearing anymore so I removed what I used in code to handle it. I'll see if I can test soon on Windows. Thanks for the heads up @puritania.

@javierjulio

This comment has been minimized.

Owner

javierjulio commented Dec 19, 2014

@rgfx @puritania I tested in Firefox on Windows and I'm able to replicate the issue. Indeed adding overflow-x: hidden; resolves the problem. From what I can tell from the inspector, no height is set by the script until you interact with the textarea or wait a few seconds and the browser will adjust the textarea to what it should be. Seems the best solution to avoid that is to add the overflow-x: hidden. I'll have that in the recommended CSS. Thanks for reporting! 👏

javierjulio added a commit that referenced this issue Dec 19, 2014

Update sample to include overflow-x: hidden;
- this is required for Firefox on Windows (the rendering issue does not
happen on Mac) #5
- update pending release notes
- add some emoji! 💪😎
@javierjulio

This comment has been minimized.

Owner

javierjulio commented Dec 19, 2014

Just released 0.4.0 with updated sample including this addition to the CSS. Thanks @rgfx and @puritania for all your help! 😄👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment