Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dynamic and better way for hooks #105

Closed
javrasya opened this issue Oct 15, 2019 · 0 comments
Closed

More dynamic and better way for hooks #105

javrasya opened this issue Oct 15, 2019 · 0 comments
Labels
Milestone

Comments

@javrasya
Copy link
Owner

@javrasya javrasya commented Oct 15, 2019

Descriptions:

Hooking to a specific event currently doesn't fulfill the main idea of django-river. Create new hooking or updating an existing one requires a code change and a redeploy.

Acceptance Criteria:

  • The current way of registering a hook via a django-river python API should be replaced by a dynamic way like creating them on the DB and have django-river see them. This way changes would be applied immediately on the hooks as well.
  • Callback functions should also be created in the DB.
  • Functions shouldn't be loaded every time it is needed. There should be something like an internal version kept that changes on every update on the function.
javrasya added a commit that referenced this issue Oct 16, 2019
javrasya added a commit that referenced this issue Oct 16, 2019
…e hooking as well and document the dynamic hooking [WIP]
javrasya added a commit that referenced this issue Oct 17, 2019
javrasya added a commit that referenced this issue Oct 17, 2019
javrasya added a commit that referenced this issue Oct 17, 2019
javrasya added a commit that referenced this issue Oct 17, 2019
javrasya added a commit that referenced this issue Oct 17, 2019
javrasya added a commit that referenced this issue Oct 17, 2019
@javrasya javrasya closed this Oct 17, 2019
@javrasya javrasya added this to the 2.1.0 milestone Oct 28, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
…e hooking as well and document the dynamic hooking [WIP]
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
…e hooking as well and document the dynamic hooking [WIP]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.