Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval status should be kept as string instead of ordinal number in DB #109

Closed
javrasya opened this issue Oct 20, 2019 · 0 comments
Closed
Labels
Milestone

Comments

@javrasya
Copy link
Owner

@javrasya javrasya commented Oct 20, 2019

Acceptance Criteria:

  • Turn status column into a string enumeration instead of a number to make it more readable in the DB and avoid mistakenly changed ordinality.
  • Write a safe custom migration to migrate the existing integer status column to the new string status column not to break the clients.
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya javrasya closed this Oct 20, 2019
javrasya added a commit that referenced this issue Oct 20, 2019
@javrasya javrasya added this to the 2.1.0 milestone Oct 28, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.