Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow is broken right after it cycles #112

Closed
javrasya opened this issue Oct 28, 2019 · 0 comments
Closed

Workflow is broken right after it cycles #112

javrasya opened this issue Oct 28, 2019 · 0 comments
Labels
bug
Milestone

Comments

@javrasya
Copy link
Owner

@javrasya javrasya commented Oct 28, 2019

Description:

The way how django-river handles the cycles is that it re-creates the rest of the workflow. The way how django-river understands that it actually cycled is that it is checking if there is any other approval that has been approved. But an approval after a cycle still makes django-river thinks that it is still cycling. It should see it as cycle if there is already a PENDING approval.

Acceptance Criteria:

  • Check if there is also no PENDING approval with the next state as source state to decide that it has cycled.
@javrasya javrasya added the bug label Oct 28, 2019
@javrasya javrasya added this to the 2.1.0 milestone Oct 28, 2019
javrasya added a commit that referenced this issue Oct 28, 2019
…ed to fix the next approval after it cycles
@javrasya javrasya closed this Oct 28, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
javrasya added a commit that referenced this issue Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.