Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It keeps recreating migration for models that have state field #77

Closed
javrasya opened this issue Jul 2, 2019 · 4 comments
Closed

It keeps recreating migration for models that have state field #77

javrasya opened this issue Jul 2, 2019 · 4 comments
Assignees
@javrasya
Labels
bug

Comments

@javrasya
Copy link
Owner

javrasya commented Jul 2, 2019

Description:

Because django-river uses a random related_name in the state field, Django thinks that the state field got updated every time we run makemigrations. It should not be recreating it.
javrasya pushed a commit that referenced this issue Jul 2, 2019
[#77] Stop recreating migrations for the models that have state field
e9cfd18
@javrasya javrasya mentioned this issue Jul 2, 2019
Closed
javrasya pushed a commit that referenced this issue Jul 2, 2019
[#77] Stop recreating migrations for the models that have state field
2ff1596
@javrasya javrasya added the bug label Jul 2, 2019
@javrasya javrasya self-assigned this Jul 2, 2019
javrasya added a commit that referenced this issue Jul 2, 2019
@javrasya
[#77] Stop recreating migrations for the models that have state field (…
69f931e 
…#78)
@superandrew
Copy link

@javrasya of course, sorry for delay, I was posting the content of the migration but I guess you were able to recreate it.

@javrasya
Copy link
Owner Author

javrasya commented Jul 2, 2019

@superandrew can you try v1.0.2 which has just been published. It must re-create the migration once and for all now.

@superandrew
Copy link

I installed 1.0.2 from pip and I can confirm that the migration isn't generated anymore in my project.

@javrasya
Copy link
Owner Author

javrasya commented Jul 2, 2019

Thank you for the contribution @superandrew . Please keep up reporting when you face some bugs. 🙏

@javrasya javrasya closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javrasya javrasya

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@superandrew @javrasya