Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It keeps recreating migration for models that have state field #77

Closed
javrasya opened this issue Jul 2, 2019 · 4 comments
Closed

It keeps recreating migration for models that have state field #77

javrasya opened this issue Jul 2, 2019 · 4 comments
Assignees
Labels
bug

Comments

@javrasya
Copy link
Owner

@javrasya javrasya commented Jul 2, 2019

Description:

Because django-river uses a random related_name in the state field, Django thinks that the state field got updated every time we run makemigrations. It should not be recreating it.

javrasya pushed a commit that referenced this issue Jul 2, 2019
javrasya pushed a commit that referenced this issue Jul 2, 2019
@javrasya javrasya added the bug label Jul 2, 2019
@javrasya javrasya self-assigned this Jul 2, 2019
javrasya added a commit that referenced this issue Jul 2, 2019
@superandrew

This comment has been minimized.

Copy link

@superandrew superandrew commented Jul 2, 2019

@javrasya of course, sorry for delay, I was posting the content of the migration but I guess you were able to recreate it.

@javrasya

This comment has been minimized.

Copy link
Owner Author

@javrasya javrasya commented Jul 2, 2019

@superandrew can you try v1.0.2 which has just been published. It must re-create the migration once and for all now.

@superandrew

This comment has been minimized.

Copy link

@superandrew superandrew commented Jul 2, 2019

I installed 1.0.2 from pip and I can confirm that the migration isn't generated anymore in my project.

@javrasya

This comment has been minimized.

Copy link
Owner Author

@javrasya javrasya commented Jul 2, 2019

Thank you for the contribution @superandrew . Please keep up reporting when you face some bugs. 🙏

@javrasya javrasya closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.