Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting on approval objects are so slow when there are many items #90

Closed
javrasya opened this issue Aug 31, 2019 · 0 comments
Closed

Getting on approval objects are so slow when there are many items #90

javrasya opened this issue Aug 31, 2019 · 0 comments
Labels
Milestone

Comments

@javrasya
Copy link
Owner

@javrasya javrasya commented Aug 31, 2019

As it is related to the issue here #36, the more items in the database the worse it gets. The reason for that is that django-river basically loop through every workflow item in the database to fine approval object on per object one by one. This is a terrible way of finding object that are on approval of a given user.

Acceptance Criteria:

  • Make the performance of this operation decent enough and also scalable.
@javrasya javrasya added the enhancement label Sep 3, 2019
@javrasya javrasya added this to the 2.0.0 milestone Sep 3, 2019
javrasya added a commit that referenced this issue Sep 4, 2019
javrasya added a commit that referenced this issue Sep 4, 2019
….11 and stop using postgres as test db and use sqlite3 back again
javrasya added a commit that referenced this issue Sep 4, 2019
javrasya added a commit that referenced this issue Sep 4, 2019
javrasya added a commit that referenced this issue Sep 4, 2019
javrasya added a commit that referenced this issue Sep 4, 2019
* [#90] Speed up finding available approvals ~ x400 times at scale.
@javrasya javrasya closed this Sep 4, 2019
javrasya added a commit that referenced this issue Sep 7, 2019
* [#90] Speed up finding available approvals ~ x400 times at scale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.