Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are so complicated and very hard to maintain and improve #93

Closed
javrasya opened this issue Sep 3, 2019 · 0 comments
Closed

Tests are so complicated and very hard to maintain and improve #93

javrasya opened this issue Sep 3, 2019 · 0 comments
Labels
enhancement
Milestone
2.0.0

Comments

@javrasya
Copy link
Owner

javrasya commented Sep 3, 2019

Descriptions:
The intention when the tests are first written is to make it generic and re-usable. This brings a lot of complexity. In one tests, many cases are tried to be handled.

Acceptance Criteria:

  • Rewrite all the tests and make them test simple cases.
  • Phrase tests according to what they are testing
  • Don't over generalize
@javrasya javrasya added this to the 2.0.0 milestone Sep 3, 2019
javrasya added a commit that referenced this issue Sep 3, 2019
@javrasya
[#93] Re-write all the tests and make them simple
6da6a12
@javrasya javrasya mentioned this issue Sep 3, 2019
Merged
javrasya added a commit that referenced this issue Sep 4, 2019
@javrasya
[#93] Make super calls compatible with python2.7
04770c1
javrasya added a commit that referenced this issue Sep 4, 2019
@javrasya
[#93] Fix code quality issues
526fc8e
javrasya added a commit that referenced this issue Sep 4, 2019
@javrasya
[#93] Re-write all the tests and make them simple (#97)
84a3737 
* [#93] Re-write and simplify all the tests
@javrasya javrasya closed this as completed Sep 4, 2019
javrasya added a commit that referenced this issue Sep 7, 2019
@javrasya
[#93] Re-write all the tests and make them simple (#97)
8bcf800 
* [#93] Re-write and simplify all the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@javrasya