Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Not working with Sheetrock/Handlebars #173

Closed
haansplosion opened this Issue Nov 28, 2013 · 3 comments

Comments

Projects
None yet
2 participants

Hi there,

Fantastic plugin!

I am having a bit of trouble running on a project that uses sheetrock to pull in google spreadsheet and handlebars to render li's out for each line in the spreadsheet.

Unfortunately, after the page is rendered list.js filters all items based on the first item in the list. So for example if I had 10 spans, only the first containing 'foo' and the rest containing 'bar', searching for foo would return all items, but searching for bar would return none.

Hope that makes sense? Any help would be much appreciated.

http://chriszarate.github.io/sheetrock/
http://handlebarsjs.com/

Owner

javve commented Feb 3, 2014

I think I'll need to see some code to understand this.
And since this seems like more of a how-to question rather than I problem in List.js I'll close this issue.

But feel free to show me a code example and I may be able to help you!

@javve javve closed this Feb 3, 2014

Hi javve,

I have since removed list.js from the project, and am unable to replicate the behaviour of all items being returned, but strangely actually the opposite...

I was trying to replicate in a JS Fiddle, but now I am getting no results for a search, as if the LI's aren't being recognised? Any help would really be appreciated!

http://jsfiddle.net/szT5P/49/

Owner

javve commented Feb 5, 2014

There were several issus in the Fiddle.

  1. The data was loaded with ajax which meant that there where no data in
    the list when List.js was loaded.
  2. Sheetrock returns a <tbody> with all the items inside which means that
    it is the <tbody> that should have class="list" and that it should not be
    <li> but <tr>'s inside the list.

Here is a working example http://jsfiddle.net/szT5P/50/ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment