From f6e6d27750ae101025bd335fc360396b6e67960e Mon Sep 17 00:00:00 2001 From: jay-tux Date: Tue, 15 Feb 2022 13:46:12 +0100 Subject: [PATCH 1/2] Deleted copy ctor/assign op on generator, implement rule of 5 --- inc/generator.hpp | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/inc/generator.hpp b/inc/generator.hpp index 32eee9c..fb38854 100644 --- a/inc/generator.hpp +++ b/inc/generator.hpp @@ -250,6 +250,33 @@ template class generator { * \param[in] p The promise to use. */ generator(promise_type &p) : _h{handle_type::from_promise(p)} {} + + /** + * \brief Copy-constructing generators results in undefined behaviour. + */ + generator(const generator &other) = delete; + /** + * \brief Moves the data from the other generator into this one. + * \param[in,out] other The other generator. + */ + generator(generator &&other) = default; + + /** + * \brief Copy-assigning generators results in undefined behaviour. + */ + generator &operator=(const generator &other) = delete; + /** + * \brief Moves the data from the other generator into this one. + * \param[in,out] other The other generator. + * \returns A reference to this generator. + */ + generator &operator=(generator &&other) = default; + + /** + * \brief Cleans up this generator's resources. + */ + ~generator() = default; + /** * \brief Converts this generator its handle. * \returns The handle for this generator. From 57942ea07fecfd894539660719366e779ade12b1 Mon Sep 17 00:00:00 2001 From: jay-tux Date: Tue, 15 Feb 2022 13:52:54 +0100 Subject: [PATCH 2/2] Made makefile generate test report --- test/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Makefile b/test/Makefile index 4f1388c..eeeab60 100644 --- a/test/Makefile +++ b/test/Makefile @@ -14,7 +14,7 @@ dirs: $(BIND)/generator: $(OBJD)/generator/test_generator.o $(CC) $< $(LDXTRA) $(LDARGS) -o $@ - $(BIND)/generator + $(BIND)/generator --gtest_output="xml:$(BIND)/" $(OBJD)/%.o: $(SRCD)/%.cpp Makefile $(CC) $(CXXARGS) $(CXXXTRA) $< -o $@