{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":81984436,"defaultBranch":"master","name":"rules_go","ownerLogin":"jayconrod","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-02-14T20:09:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/164791?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1710633011.0","currentOid":""},"activityList":{"items":[{"before":"fd98ff2cf29b15d7ac06e943b6fa2e5825fe3dc5","after":"3364dce8cbe255abbaece149d0633158777df603","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-03-20T23:07:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"make test work with and without bzlmod","shortMessageHtmlLink":"make test work with and without bzlmod"}},{"before":null,"after":"dbe90cfdf357ab0ee9cd1c813cbbc567185d01c4","ref":"refs/heads/fix-test-version","pushedAt":"2024-03-16T23:50:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"gopackagesdriver: fix version check with Bazel development versions\n\nFixes #3889","shortMessageHtmlLink":"gopackagesdriver: fix version check with Bazel development versions"}},{"before":"8c335934913ab4e26afd4392f9404bcd908ad1e9","after":"fd98ff2cf29b15d7ac06e943b6fa2e5825fe3dc5","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-03-13T23:36:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"remove debug code","shortMessageHtmlLink":"remove debug code"}},{"before":"f359b9a9448c72ddb1a82850255ac091f810d823","after":"8c335934913ab4e26afd4392f9404bcd908ad1e9","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-03-13T23:29:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"debug","shortMessageHtmlLink":"debug"}},{"before":"eabc988f36645e8f8d92d1e97ae13aad9c8e0cd5","after":null,"ref":"refs/heads/move-gpd-test","pushedAt":"2024-03-13T23:26:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"}},{"before":"97925b770b610ffdd94ee114edf77699ae3ce772","after":"eabc988f36645e8f8d92d1e97ae13aad9c8e0cd5","ref":"refs/heads/move-gpd-test","pushedAt":"2024-03-11T22:37:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"fix review comment","shortMessageHtmlLink":"fix review comment"}},{"before":"e085a7659f827dcd57dc4838eceb04910c1c973a","after":"97925b770b610ffdd94ee114edf77699ae3ce772","ref":"refs/heads/move-gpd-test","pushedAt":"2024-03-08T23:54:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"restore output directory path","shortMessageHtmlLink":"restore output directory path"}},{"before":"5e026e2daec6d0f5921c9eb2c16e1f3cc62c378c","after":"f359b9a9448c72ddb1a82850255ac091f810d823","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-02-11T03:58:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"fix test","shortMessageHtmlLink":"fix test"}},{"before":"2abfe08c252cca9df0bb577a678c381fcecce3b7","after":"e085a7659f827dcd57dc4838eceb04910c1c973a","ref":"refs/heads/move-gpd-test","pushedAt":"2024-02-11T03:55:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"gopackagesdriver: move and simplify test\n\nMoved //tests/integration/gopackagesdriver:gopackagesdriver_test\nto //go/tools/gopackagesdriver:gopackagesdriver_test.\n\nPreviously the test invoked gopackagesdriver with 'bazel run'\nin a temporary workspace, which forced Bazel to build it, slowing\ndown the test significantly, especially on Windows. Now, the test\nembeds the gopackagesdriver library and invokes it directly.\nThe driver still runs in a temporary workspace and still needs to\ninvoke bazel, so the test is still slow, but it's faster than before.\n\nAlso, a number of other improvements:\n\n- gopackagesdriver now sets --consistent_labels if the bazel version\n  is 6.4.0 or later instead of guessing based on the link-stamped\n  rules_go repo name.\n- bazel_testing.BazelCmd now writes --output_user_root to a .bazelrc\n  file instead of passing it to commands. gopackagesdriver invokes\n  bazel directly, so this lets it use the same output root.","shortMessageHtmlLink":"gopackagesdriver: move and simplify test"}},{"before":null,"after":"2abfe08c252cca9df0bb577a678c381fcecce3b7","ref":"refs/heads/move-gpd-test","pushedAt":"2024-02-11T03:28:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"gopackagesdriver: move and simplify test\n\nMoved //tests/integration/gopackagesdriver:gopackagesdriver_test\nto //go/tools/gopackagesdriver:gopackagesdriver_test.\n\nPreviously the test invoked gopackagesdriver with 'bazel run'\nin a temporary workspace, which forced Bazel to build it, slowing\ndown the test significantly, especially on Windows. Now, the test\nembeds the gopackagesdriver library and invokes it directly.\nThe driver still runs in a temporary workspace and still needs to\ninvoke bazel, so the test is still slow, but it's faster than before.\n\nAlso, a number of other improvements:\n\n- gopackagesdriver now sets --consistent_labels if the bazel version\n  is 6.4.0 or later instead of guessing based on the link-stamped\n  rules_go repo name.\n- bazel_testing.BazelCmd now writes --output_user_root to a .bazelrc\n  file instead of passing it to commands. gopackagesdriver invokes\n  bazel directly, so this lets it use the same output root.","shortMessageHtmlLink":"gopackagesdriver: move and simplify test"}},{"before":"2abfe08c252cca9df0bb577a678c381fcecce3b7","after":null,"ref":"refs/heads/fix-bazel-testing-windows","pushedAt":"2024-02-11T03:28:30.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"}},{"before":null,"after":"2abfe08c252cca9df0bb577a678c381fcecce3b7","ref":"refs/heads/fix-bazel-testing-windows","pushedAt":"2024-02-11T03:27:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"gopackagesdriver: move and simplify test\n\nMoved //tests/integration/gopackagesdriver:gopackagesdriver_test\nto //go/tools/gopackagesdriver:gopackagesdriver_test.\n\nPreviously the test invoked gopackagesdriver with 'bazel run'\nin a temporary workspace, which forced Bazel to build it, slowing\ndown the test significantly, especially on Windows. Now, the test\nembeds the gopackagesdriver library and invokes it directly.\nThe driver still runs in a temporary workspace and still needs to\ninvoke bazel, so the test is still slow, but it's faster than before.\n\nAlso, a number of other improvements:\n\n- gopackagesdriver now sets --consistent_labels if the bazel version\n  is 6.4.0 or later instead of guessing based on the link-stamped\n  rules_go repo name.\n- bazel_testing.BazelCmd now writes --output_user_root to a .bazelrc\n  file instead of passing it to commands. gopackagesdriver invokes\n  bazel directly, so this lets it use the same output root.","shortMessageHtmlLink":"gopackagesdriver: move and simplify test"}},{"before":"c698f4840d6d35b713ae6184500239b57c9eec29","after":"5e026e2daec6d0f5921c9eb2c16e1f3cc62c378c","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-02-09T15:43:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fmeum","name":"Fabian Meumertzheim","path":"/fmeum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4312191?s=80&v=4"},"commit":{"message":"make test work with and without bzlmod","shortMessageHtmlLink":"make test work with and without bzlmod"}},{"before":"15ff1595b36e30f8ef20101a8137726ba771d306","after":"c698f4840d6d35b713ae6184500239b57c9eec29","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-01-03T01:39:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"make test work with and without bzlmod","shortMessageHtmlLink":"make test work with and without bzlmod"}},{"before":"7a33d8bd384fdbd81baca861a0cec50f6fa13302","after":"15ff1595b36e30f8ef20101a8137726ba771d306","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-01-02T20:00:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fmeum","name":"Fabian Meumertzheim","path":"/fmeum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4312191?s=80&v=4"},"commit":{"message":"add test","shortMessageHtmlLink":"add test"}},{"before":"38a7ae90dcadcda69580a05e9ee0e26a5a4ea64b","after":"7a33d8bd384fdbd81baca861a0cec50f6fa13302","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2024-01-02T19:48:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"add test","shortMessageHtmlLink":"add test"}},{"before":null,"after":"38a7ae90dcadcda69580a05e9ee0e26a5a4ea64b","ref":"refs/heads/fix-gopackagesdriver-incompatible","pushedAt":"2023-12-29T20:15:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"gopackagesdriver: skip root packages that can't be built\n\nFixes #3805","shortMessageHtmlLink":"gopackagesdriver: skip root packages that can't be built"}},{"before":"3571ce61c9fe8651c2491cbf7d55fb54c02974a1","after":"6ba614f44f076cf166f5150579d9d2dbaf4bb720","ref":"refs/heads/fix-test-rundir","pushedAt":"2023-09-07T18:00:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"not","shortMessageHtmlLink":"not"}},{"before":"e17d02e9ef9c85355d83d2c66bab8d875cfea2e8","after":"3571ce61c9fe8651c2491cbf7d55fb54c02974a1","ref":"refs/heads/fix-test-rundir","pushedAt":"2023-09-07T17:50:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"address review feedback","shortMessageHtmlLink":"address review feedback"}},{"before":"ed6e8fe8c5bb5a06ceb4d12a1ddd0c431bb2ed21","after":"e17d02e9ef9c85355d83d2c66bab8d875cfea2e8","ref":"refs/heads/fix-test-rundir","pushedAt":"2023-09-06T20:24:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"bzltestutil: move os.Chdir call into new package\n\nSorry for missing this the first time in #3679. The package init algorithm\nwas a little different than I thought, and I imagined that Go 1.21\nwas already in use, so I didn't look into it deeply.\n\nThe problem was that even though \"+initfirst/.../bzlutil\" sorts lower than\nother packages, it imports \"sync\" and a number of other std packages\nthat sort higher than \"github.com/...\" user packages. If a user package\nhas no dependencies, it's eligible to be initialized before bzltestutil,\neven with the lower name.\n\nI moved the init function with the os.Chdir call into a separate tiny package\nthat only imports \"os\" and \"runtime\". It should get initialized much earlier.\n\nFixes #3675","shortMessageHtmlLink":"bzltestutil: move os.Chdir call into new package"}},{"before":null,"after":"ed6e8fe8c5bb5a06ceb4d12a1ddd0c431bb2ed21","ref":"refs/heads/fix-test-rundir","pushedAt":"2023-09-05T21:00:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"bzltestutil: set importmap to fix run_dir\n\nGo 1.21 clarified package initialization order and changed behavior:\npackages with lexicographically lower paths are now initialized earlier.\n\nWe need bzltestutil to initialize before user packages so it can\nchange to the correct directory. To accomplish this, we set an importmap\nprefix that starts with '+', the lowest allowed character.\n\nFixes #3675","shortMessageHtmlLink":"bzltestutil: set importmap to fix run_dir"}},{"before":"3d706b2812acc6186f850664ff17331c0639f507","after":"f26927e022aa9cf28b73c4943cccabaee1eea70d","ref":"refs/heads/fix-download-sdk","pushedAt":"2023-06-01T23:37:31.297Z","pushType":"push","commitsCount":6,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"version check","shortMessageHtmlLink":"version check"}},{"before":"fd6d2ad4907b118f88568ab890f3455c24ad3efb","after":"3d706b2812acc6186f850664ff17331c0639f507","ref":"refs/heads/fix-download-sdk","pushedAt":"2023-05-25T18:47:00.327Z","pushType":"push","commitsCount":7,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"Merge branch 'master' into fix-download-sdk","shortMessageHtmlLink":"Merge branch 'master' into fix-download-sdk"}},{"before":"f07c1750bd6c0eac0a34d8d4f5ef076dddbeb976","after":"fd6d2ad4907b118f88568ab890f3455c24ad3efb","ref":"refs/heads/fix-download-sdk","pushedAt":"2023-05-25T18:46:37.879Z","pushType":"push","commitsCount":1,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"use rename_files; rewrite comment","shortMessageHtmlLink":"use rename_files; rewrite comment"}},{"before":"375a8e7179dce109fbae6f5f2740b78b76ebf573","after":"f07c1750bd6c0eac0a34d8d4f5ef076dddbeb976","ref":"refs/heads/fix-download-sdk","pushedAt":"2023-05-17T20:53:23.522Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"go_download_sdk: apply extraction workaround to zips on non-windows OSs\n\nThe Go distribution contains at least one test file with an invalid\nunicode name. Bazel cannot extract the distribution archive on some\noperating systems and file systems; Darwin with AFS at least is affected.\n\nFor .tar.gz files, we workaround the failure in ctx.download_and_extract\nby using the native system tar.\n\nThis PR applies a similar workaround for .zip files on non-Windows OSs.\nWindows itself is not affected (ctx.download_and_extract works),\nso the workaround is not applied there. This is only really needed\nwhen you have a Darwin host and a Windows executor (don't ask).\n\nFor #2771","shortMessageHtmlLink":"go_download_sdk: apply extraction workaround to zips on non-windows OSs"}},{"before":null,"after":"375a8e7179dce109fbae6f5f2740b78b76ebf573","ref":"refs/heads/fix-download-sdk","pushedAt":"2023-05-17T20:47:38.416Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jayconrod","name":"Jay Conrod","path":"/jayconrod","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/164791?s=80&v=4"},"commit":{"message":"go_download_sdk: apply extraction workaround to zips on non-windows OSs\n\nThe Go distribution contains at least one test file with an invalid\nunicode name. Bazel cannot extract the distribution archive on some\noperating systems and file systems; Darwin with AFS at least is affected.\n\nFor .tar.gz files, we workaround the failure in ctx.download_and_extract\nby using the native system tar.\n\nThis PR applies a similar workaround for .zip files on non-Windows OSs.\nWindows itself is not affected (ctx.download_and_extract works),\nso the workaround is not applied there. This is only really needed\nwhen you have a Darwin host and a Windows executor (don't ask).\n\nFor #2771","shortMessageHtmlLink":"go_download_sdk: apply extraction workaround to zips on non-windows OSs"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEGy8CdgA","startCursor":null,"endCursor":null}},"title":"Activity · jayconrod/rules_go"}