Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest versions are very slow #126

Closed
synic opened this issue Sep 10, 2015 · 13 comments
Closed

Latest versions are very slow #126

synic opened this issue Sep 10, 2015 · 13 comments

Comments

@synic
Copy link

@synic synic commented Sep 10, 2015

I've updated to the latest git, and it seems there's something new that's causing some lag when opening and closing nodes, and searching.

@jaypei
Copy link
Owner

@jaypei jaypei commented Sep 10, 2015

Hi synic,

Is there any message in the "Message" buffer?

@synic
Copy link
Author

@synic synic commented Sep 10, 2015

Unfortunately, no. It seems to have been whatever change was on the 5th.

@synic
Copy link
Author

@synic synic commented Sep 10, 2015

Yeah, definitely something wonky. Maybe just a spacemacs itself issue? I feel like you would notice it right away if it was affecting you. It takes 2-3 seconds just to expand a directory that only has 10 files in it.

EDIT: It is spacemacs: syl20bnr/spacemacs#2943

@synic
Copy link
Author

@synic synic commented Sep 10, 2015

More Info: It doesn't seem to happen to every directory. It seems to happen to directories under git source control, that have a lot of history.

If I close emacs, rm -rf .git and go back to that directory, it is very fast again.

@synic
Copy link
Author

@synic synic commented Sep 10, 2015

Sorry for the bug spam here. I've got steps to reproduce:

$ git clone git@github.com:emacs-mirror/emacs.git

Then, navigate to the new emacs directory in NeoTree, and try expanding the first directory, admin. There should be some significant lag.

I'm on a MacBook Pro running Yosemite, using https://github.com/railwaycat/emacs-mac-port from homebrew.

@synic
Copy link
Author

@synic synic commented Sep 11, 2015

Really really sorry for the spam.

It appears to be the combination of neotree and helm-projectile. If I install only these on vanilla emacs, the problem occurs.

@jaypei jaypei added the bug label Sep 12, 2015
@jaypei
Copy link
Owner

@jaypei jaypei commented Sep 12, 2015

Sorry, according to your method, I still cannot recurrence the problem, are you enable the option 'neo-vc-integration'?

@synic
Copy link
Author

@synic synic commented Sep 12, 2015

Yes, that is the problem. If set neo-vc-integration to nil, it is fast again.

Is there any way to speed that up?

@jaypei jaypei added question and removed bug question labels Sep 13, 2015
@jaypei
Copy link
Owner

@jaypei jaypei commented Sep 13, 2015

Yes, this feature is indeed slow, so it is closed by default.
It can speed up when NeoTree support the sub-tree refresh feature.

@razum2um
Copy link

@razum2um razum2um commented Oct 22, 2015

thanks for (setq neo-vc-integration nil)
it should be mentioned in README, what do you think?

@mmlac
Copy link

@mmlac mmlac commented Nov 12, 2015

I don't think this issue is fixed. A simple single i.e. git status should be enough to update the full tree, and it is not bound to the history of the project.

Is there a way to optimize the feature to be usable? At the current state it does more harm than good in any even medium sized projects.

@palikar
Copy link
Collaborator

@palikar palikar commented Nov 13, 2018

I don't think the bug is in recent versions of neotree. I've just tested the VC integration everything works smoothly.

@palikar palikar closed this Nov 13, 2018
@love2dishtech
Copy link

@love2dishtech love2dishtech commented Mar 20, 2019

Since the bug is closed, has this been fixed. Documentation still points it is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.