diff --git a/bears/java/CheckstyleBear.py b/bears/java/CheckstyleBear.py index 370294a790..9326892c04 100644 --- a/bears/java/CheckstyleBear.py +++ b/bears/java/CheckstyleBear.py @@ -33,7 +33,7 @@ def known_checkstyle_or_path(setting): @linter(executable='java', output_format='regex', - output_regex=r'\[(?PWARN|INFO)\].*?' + output_regex=r'\[(?PWARN|INFO|ERROR)\].*?' r'(?P\d+):?(?P\d+)?. ' r'(?P.*?) *\[(?P[a-zA-Z]+?)\]') class CheckstyleBear: diff --git a/tests/java/CheckstyleBearTest.py b/tests/java/CheckstyleBearTest.py index 0cae329971..b9eed1b56d 100644 --- a/tests/java/CheckstyleBearTest.py +++ b/tests/java/CheckstyleBearTest.py @@ -24,24 +24,24 @@ def setUp(self): self.empty_config = os.path.join(test_files, 'checkstyle_empty_config.xml') - def test_run(self): - self.check_validity(self.uut, [], self.good_file) - self.check_validity(self.uut, [], self.bad_file, valid=False) - def test_style_google(self): self.section['checkstyle_configs'] = 'google' self.check_validity(self.uut, [], self.good_file) + self.check_validity(self.uut, [], self.bad_file, valid=False) def test_style_sun(self): self.section['checkstyle_configs'] = 'sun' - self.check_validity(self.uut, [], self.good_file) + self.check_validity(self.uut, [], self.good_file, valid=False) + self.check_validity(self.uut, [], self.bad_file, valid=False) def test_style_android(self): self.section['checkstyle_configs'] = 'android-check-easy' self.check_validity(self.uut, [], self.good_file) + self.check_validity(self.uut, [], self.bad_file, valid=False) self.section['checkstyle_configs'] = 'android-check-hard' self.check_validity(self.uut, [], self.good_file) + self.check_validity(self.uut, [], self.bad_file, valid=False) def test_config_failure_use_spaces(self): self.section['checkstyle_configs'] = 'google'