New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native related fixes #118
Merged
Merged
Native related fixes #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using native dependency - applied patch
…- escapes the windows file separator now
…rt tying in the stripper
… strips final library - will need to change stripper depending on os
…ars temp include files directories
…seemed to have worked
… strips final library - now supports strip binary for mac and windows as well Issue 264: NDK build doesn't work on Windows: PatternSyntaxException - now uses the ndk-build.cmd used in the windows ndk
Added configuration parameters for the -f cmd line flag Added ability to specify the final name of the library to use (e.g. the final output of the build) - so that it does not have to match the artifact id etc
fixed failing test
…gs Object added debug mode in APK mojo to allow it to include gdbserver - some minor refactoring to move some common variables to abstract mojo
…in into native-related-fixes
sorted out parameters
thanks! |
Thank you for all that GREAT work.. I really need to get into it again too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes a variety issues logged in the issue tracker:
255: Apk does not contain native libs in 'libs/armeabi' during
264: NDK build doesn't work on Windows: PatternSyntaxException
265: NDK Build leaves generated .so unstripped thus large
277: NDK build leaves a lot of temporary files around
It also add adds initial support for building APKs that will support native debugging (it now includes the gdbserver if apkDebug is set to true).
Sadly, i had to disable the handling of configuration at this stage - will see if I get some more time later.
Let me know if you have any issues pulling this in - all native samples should work as is btw.
Cheers,
Johan