New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OEmbed and OpenGraph post previews #79

Merged
merged 14 commits into from Jan 4, 2017

Conversation

2 participants
@jaywink
Owner

jaywink commented Dec 18, 2016

OEmbed comes first, fallback to OpenGraph (first url only).

Closes #16

TODO:

  • Add tests
  • Fix URL capturing regex

@jaywink jaywink added the in progress label Dec 18, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 18, 2016

Current coverage is 96.42% (diff: 100%)

Merging #79 into master will increase coverage by 0.63%

@@             master        #79   diff @@
==========================================
  Files            30         31     +1   
  Lines           760        868   +108   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            728        837   +109   
+ Misses           32         31     -1   
  Partials          0          0          

Powered by Codecov. Last update c64b51d...fee74a6

codecov-io commented Dec 18, 2016

Current coverage is 96.42% (diff: 100%)

Merging #79 into master will increase coverage by 0.63%

@@             master        #79   diff @@
==========================================
  Files            30         31     +1   
  Lines           760        868   +108   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            728        837   +109   
+ Misses           32         31     -1   
  Partials          0          0          

Powered by Codecov. Last update c64b51d...fee74a6

jaywink added some commits Dec 17, 2016

Add OEmbed and OpenGraph post previews
OEmbed comes first, fallback to OpenGraph (first url only).

Closes #16
Monkeypatch request.get/post in tests
Ensure no network calls are made through these at least.
Fix invalid test_returns_existing_profile test
Was not testing the correct thing, which is remote user local Profile key finding.
Unify some test case names
Prefix them with Test instead of postfixing with TestCase - more pytesty.
Make grid layouting with oembeds more robust
Instead of looking at ajax calls, specifically watch for new iframes on the page and do a layout after one is seen. Do these checks for up to 10s after page loading.

Refs: #16

@jaywink jaywink merged commit f2decb2 into master Jan 4, 2017

5 checks passed

code-quality/landscape Code quality increased by 0.10%
Details
codecov/patch 100% of diff hit (target 95.78%)
Details
codecov/project 96.42% (+0.63%) compared to c64b51d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jaywink jaywink deleted the oembed branch Jan 4, 2017

@jaywink jaywink removed the in progress label Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment