Add OEmbed and OpenGraph post previews #79

Merged
merged 14 commits into from Jan 4, 2017

Projects

None yet

2 participants

@jaywink
Owner
jaywink commented Dec 18, 2016 edited

OEmbed comes first, fallback to OpenGraph (first url only).

Closes #16

TODO:

  • Add tests
  • Fix URL capturing regex
@jaywink jaywink added the in progress label Dec 18, 2016
@codecov-io
codecov-io commented Dec 18, 2016 edited

Current coverage is 96.42% (diff: 100%)

Merging #79 into master will increase coverage by 0.63%

@@             master        #79   diff @@
==========================================
  Files            30         31     +1   
  Lines           760        868   +108   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            728        837   +109   
+ Misses           32         31     -1   
  Partials          0          0          

Powered by Codecov. Last update c64b51d...fee74a6

added some commits Dec 17, 2016
@jaywink Add OEmbed and OpenGraph post previews
OEmbed comes first, fallback to OpenGraph (first url only).

Closes #16
97c3669
@jaywink Ensure OpenGraph doesn't remember old data
Refs: #16
15e0d48
@jaywink Ensure fetching content preview never crashes
Refs: #16
c18ee45
@jaywink Monkeypatch request.get/post in tests
Ensure no network calls are made through these at least.
98a9049
@jaywink Fix invalid test_returns_existing_profile test
Was not testing the correct thing, which is remote user local Profile key finding.
c27a0c1
@jaywink Unify some test case names
Prefix them with Test instead of postfixing with TestCase - more pytesty.
4fcea06
@jaywink Add tests for fetch_content_preview
Refs: #16
fdb9e17
@jaywink Add freezegun to test requirements 37ccc07
@jaywink Add tests for fetch_opengraph_preview
Refs: #16
a5485f8
@jaywink Write tests for fetch_oembed_preview
Refs: #16
d23f29c
@jaywink Fix a few code style issues
Refs: #16
e3354e2
@jaywink Improve fetch_oembed_preview tests
Refs: #16
bef5ec4
@jaywink Add tests for content.signals.fetch_preview
Refs: #16
77032ac
@jaywink Make grid layouting with oembeds more robust
Instead of looking at ajax calls, specifically watch for new iframes on the page and do a layout after one is seen. Do these checks for up to 10s after page loading.

Refs: #16
fee74a6
@jaywink jaywink merged commit f2decb2 into master Jan 4, 2017

5 checks passed

code-quality/landscape Code quality increased by 0.10%
Details
codecov/patch 100% of diff hit (target 95.78%)
Details
codecov/project 96.42% (+0.63%) compared to c64b51d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jaywink jaywink deleted the oembed branch Jan 4, 2017
@jaywink jaywink removed the in progress label Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment