Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fadeDuration option added #90

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

ahmetb commented Jan 23, 2012

I just added a fadeDuration options that makes use of duration parameter of jQuery animation functions. I hope there's nothing wrong with my code styling. Sincerely

ahmet alp balkan

ahmetb commented Dec 12, 2012

Hi, just wanted to bring this up. This is still ready to auto-merge.

Any chance of fixing up the coding style here? It's a weird way to do the linebreak.

I'd love to fix if you tell me how can I do that. This is some kinda old pull request and still unnoticed by maintainers. So do you think is it worth doing?

Just push more commits to whatever branch the original was on. At the moment, I'm just merging a bunch of pull requests - either my fork will become the 'best fork'; or the original maintainer will have a one-click-merge-lots PR to deal with - so yeah, it's probably worth it.

We better contact @jaz303 in this case so that he can disable/redirect his repo to yours. Otherwise nobody out there will notice your 'best fork' and thus it will probably not worth it.

ahmetb commented Jan 17, 2015

screw that.

@ahmetb ahmetb closed this Jan 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment