setup.py does not fallback to using distutils.core import setup #13

Closed
allanhaywood opened this Issue Apr 18, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@allanhaywood
Contributor

allanhaywood commented Apr 18, 2017

In all of the setup.py scripts I have used before, the import for setup is like this:

try:
from setuptools import setup
except ImportError:
from distutils.core import setup

Which allows it to fall back to distutils.core if setuptools is not available.

Is there a reason that this is missing from this projects setup.py?

Thanks.

@ncoghlan

This comment has been minimized.

Show comment
Hide comment
@ncoghlan

ncoghlan Apr 22, 2017

Collaborator

Only the fact that setup.py bdist_wheel only works with setuptools, and that was the original motivation for moving away from plain distutils.

I'd accept a PR to add the fallback, as the setup call itself doesn't rely on any setuptools features, so it should be enough to get setup.py install working again under plain distutils.

Collaborator

ncoghlan commented Apr 22, 2017

Only the fact that setup.py bdist_wheel only works with setuptools, and that was the original motivation for moving away from plain distutils.

I'd accept a PR to add the fallback, as the setup call itself doesn't rely on any setuptools features, so it should be enough to get setup.py install working again under plain distutils.

@allanhaywood

This comment has been minimized.

Show comment
Hide comment
@allanhaywood

allanhaywood Apr 24, 2017

Contributor

Thanks. I submitted a PR, let me know if there is anything additional needed on my end.

Contributor

allanhaywood commented Apr 24, 2017

Thanks. I submitted a PR, let me know if there is anything additional needed on my end.

@ncoghlan ncoghlan closed this in #14 Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment