Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated smart_text() with smart_str() #295

Closed
wants to merge 3 commits into from
Closed

Replace deprecated smart_text() with smart_str() #295

wants to merge 3 commits into from

Conversation

sp1thas
Copy link
Contributor

@sp1thas sp1thas commented Mar 10, 2021

The purpose of this PR is to solve #267 by replacing django.utils.encoding.smart_text with django.utils.encoding.smart_str whenever is applicable (Django >= 3.0)

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #295 (938b16e) into master (d77803b) will decrease coverage by 0.29%.
The diff coverage is 66.66%.

❗ Current head 938b16e differs from pull request most recent head 4e7879f. Consider uploading reports for the commit 4e7879f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   81.94%   81.65%   -0.30%     
==========================================
  Files          18       18              
  Lines         493      496       +3     
==========================================
+ Hits          404      405       +1     
- Misses         89       91       +2     
Impacted Files Coverage Δ
auditlog/diff.py 84.61% <66.66%> (-2.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77803b...4e7879f. Read the comment docs.

auditlog/diff.py Outdated Show resolved Hide resolved
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@hramezani
Copy link
Member

@sp1thas Thanks for the PR. I include your change into #302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemovedInDjango40Warning: smart_text() is deprecated in favor of smart_str()
2 participants