New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change requests.get kwarg from data to params when calling SoundCloud AP... #28

Merged
merged 1 commit into from Jun 24, 2014

Conversation

Projects
None yet
3 participants
@rolo
Contributor

rolo commented Jun 24, 2014

This was failing for me with an error 400 error, and the requests docs (http://docs.python-requests.org/en/latest/user/quickstart/#passing-parameters-in-urls) say to use a kwarg called params rather than data. I've changed this and it now works. Not sure if this is something which has changed in the requests lib.

@coveralls

This comment has been minimized.

coveralls commented Jun 24, 2014

Coverage Status

Coverage remained the same when pulling 1133071 on rolo:patch-1 into bccaec0 on yetty:master.

yetty added a commit that referenced this pull request Jun 24, 2014

Merge pull request #28 from rolo/patch-1
Change requests.get kwarg from data to params when calling SoundCloud AP...

@yetty yetty merged commit a3f357e into jazzband:master Jun 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@yetty

This comment has been minimized.

Collaborator

yetty commented Jun 24, 2014

Thanks.

@yetty yetty added this to the v0.11 milestone Jul 1, 2014

@yetty yetty added the bug label Jul 1, 2014

yetty added a commit that referenced this pull request Jul 1, 2014

@yetty yetty referenced this pull request Jul 11, 2014

Closed

SoundCloud not working #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment