New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Vimeo channels (eg. Staff picks) #47

merged 1 commit into from Dec 18, 2014


None yet
2 participants

fertringer commented Dec 17, 2014

I noticed the featured videos on Vimeo's home page tend to be "staff picks", which have a different url structure, probably to give some extra context to the view that renders the video. These videos can also be accessed through the more traditional url path, but because the staffpicks links are on the home page, I am concerned my users will be trying to paste in what they think are valid video urls, only to have them failing.

This adjusted regex is a bit aggressive, allowing for other channels to host videos (currently I don't believe any do, but they might if the staff picks are able to), so that could be tweaked.

yetty added a commit that referenced this pull request Dec 18, 2014

Merge pull request #47 from fertringer/master
Adding support for Vimeo channels (eg. Staff picks)

@yetty yetty merged commit 1385281 into jazzband:master Dec 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed

@yetty yetty added this to the v1.0.0 milestone Dec 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment