New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secure connection to query soundcloud endpoint #68

Merged
merged 3 commits into from Apr 20, 2017

Conversation

Projects
None yet
3 participants
@Hopiu
Contributor

Hopiu commented Feb 27, 2017

Use https to query the Soundcloud oembed endpoint if is_secure is set on the Soundcloud backend.

@CedricCarrard

This comment has been minimized.

Member

CedricCarrard commented Mar 18, 2017

@Hopiu Thanks for pull request but please fix test.

Hopiu Hopiu
urllib3 1.20 bundled with requests 2.13.0 uses loglevel DEBUG instead…
… of INFO for timeout, update expected test output
@SalahAdDin

This comment has been minimized.

Contributor

SalahAdDin commented Mar 22, 2017

👍 Good!

@CedricCarrard CedricCarrard removed the invalid label Mar 28, 2017

@CedricCarrard

This comment has been minimized.

Member

CedricCarrard commented Mar 28, 2017

@Hopiu Your pull request will be merge in the version 1.2

@CedricCarrard CedricCarrard merged commit 2fa2699 into jazzband:master Apr 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment