Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable default HTTPS support #86
referenced this pull request
Apr 6, 2018
Oof! I've deleted some urls from https://github.com/jazzband/django-embed-video/pull/86/files#diff-f92ad249831b527c54fad3b729d24754 I shouldn't have. Fixing...
@CedricCarrard this looks good to me! Seems to pass tests and works in one of my apps that uses this.
I was initially a little concerned about
is_secure = True being set individually for the three builtin VideoBackend subclasses, but I think that makes more sense than setting in
VideoBackend directly because that'd probably be considered a breaking change.
Good work, @marcosguedes!