New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renderer kwarg to Widget render method to support Python 2.1 and later. #88

Merged
merged 3 commits into from Sep 3, 2018

Conversation

Projects
None yet
2 participants
@mgrdcm
Member

mgrdcm commented Aug 12, 2018

The Admin widget currently doesn't work in Django>=2.1 because:

From: https://docs.djangoproject.com/en/1.11/ref/forms/widgets/#django.forms.Widget.render

Changed in Django 1.11:
The renderer argument was added. Support for subclasses that don’t accept it will be removed in Django 2.1.

The automated tests should pass once #89 is merged into master and then into this branch.

Add renderer kwarg to Widget render method to support Python 2.1 and …
…later.

The Admin widget currently doesn't work in Django>=2.1:

From: https://docs.djangoproject.com/en/1.11/ref/forms/widgets/#django.forms.Widget.render
Changed in Django 1.11:
The renderer argument was added. Support for subclasses that don’t accept it will be removed in Django 2.1.
@mgrdcm

This comment has been minimized.

Member

mgrdcm commented Aug 15, 2018

BTW in case anyone else runs into this, I'm currently using this code to work around the bug in Django>=2.1 until this PR gets merged and released: https://gist.github.com/mgrdcm/f6e62b7eac741e93082a82a91138b1f1

CedricCarrard added some commits Aug 31, 2018

@CedricCarrard

This comment has been minimized.

Member

CedricCarrard commented Aug 31, 2018

@mgrdcm Please look to correct the tests thanks.

@mgrdcm

This comment has been minimized.

Member

mgrdcm commented Aug 31, 2018

@CedricCarrard it was just a timeout - reran the tests and all passed!

@mgrdcm mgrdcm requested a review from CedricCarrard Aug 31, 2018

@mgrdcm mgrdcm self-assigned this Aug 31, 2018

@CedricCarrard CedricCarrard merged commit 9c786b7 into jazzband:master Sep 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mgrdcm

This comment has been minimized.

Member

mgrdcm commented Sep 4, 2018

Thanks @CedricCarrard! Think this might now be ready for a 1.2.0 release so that the package works with Django 2.1? Would also close out #90. Happy to do anything else to help that process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment