Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prompt login #1164

Merged
merged 2 commits into from Jun 3, 2022
Merged

Support prompt login #1164

merged 2 commits into from Jun 3, 2022

Conversation

jesseyay
Copy link
Contributor

@jesseyay jesseyay commented May 20, 2022

Hi team, thanks for the great library!

Description of the Change

Adds support for prompt=login to comply with https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1164 (95935dc) into master (c22c179) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
+ Coverage   96.87%   96.90%   +0.03%     
==========================================
  Files          31       31              
  Lines        1794     1812      +18     
==========================================
+ Hits         1738     1756      +18     
  Misses         56       56              
Impacted Files Coverage Δ
oauth2_provider/views/base.py 97.88% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22c179...95935dc. Read the comment docs.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks! Please see a couple of documentation suggestions.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/oidc.rst Outdated Show resolved Hide resolved
@n2ygk n2ygk added this to the 2.1.0 milestone May 27, 2022
@jesseyay
Copy link
Contributor Author

Hey thanks! Please see a couple of documentation suggestions.

Yep makes sense, thanks for the review :)

Co-authored-by: Alan Crosswell <alan@crosswell.us>
@n2ygk
Copy link
Member

n2ygk commented Jun 3, 2022

darn it, I tried to rebase to fix the CHANGELOG conflict...

@n2ygk n2ygk merged commit 0f18817 into jazzband:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants