Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on Collector behaviour needs clarification #558

Open
Spacerat opened this issue Mar 31, 2016 · 0 comments
Open

Documentation on Collector behaviour needs clarification #558

Spacerat opened this issue Mar 31, 2016 · 0 comments

Comments

@Spacerat
Copy link
Contributor

After grappling with some speed issues in develop mode, I realised that Collector.collect() was being run for every pipeline tag in my project. Eventually I narrowed my issue down to this:

https://github.com/jazzband/django-pipeline/blob/master/pipeline/collector.py#L31-L32

request was always None for me, and so the solution was to add 'django.core.context_processors.request' to my project's TEMPLATES['OPTIONS']['context_processors'] option which gave me a roughly 6x speedup.

I imagine it's probably enough to just add something to the documentation which instructs users to add the context processor if they intend to use multiple tags, although I'm not sure where. Installation→Recommendations could work, or maybe near the top of the Usage or Configuration sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant