Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor settings to make possible override in settings #72

Merged
merged 1 commit into from Feb 11, 2017

Conversation

yakky
Copy link
Member

@yakky yakky commented Feb 7, 2017

This refactor the settings to make easy to override by using https://docs.djangoproject.com/en/1.10/topics/testing/tools/#overriding-settings

Trick by Guido Van Rossum himself:

# module foo.py

import sys

class Foo:
    def funct1(self, <args>): <code>
    def funct2(self, <args>): <code>

sys.modules[__name__] = Foo()

See https://mail.python.org/pipermail/python-ideas/2012-May/014969.html

@yakky yakky added the feature label Feb 7, 2017
@yakky yakky added this to the 3.0 milestone Feb 7, 2017
@yakky
Copy link
Member Author

yakky commented Feb 7, 2017

anyone available for a review?

@yakky yakky force-pushed the feature/settings_refactoring branch from d8871c1 to 3258fa1 Compare February 7, 2017 12:31
@codecov
Copy link

codecov bot commented Feb 7, 2017

Codecov Report

Merging #72 into master will increase coverage by 0.29%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage    62.4%   62.69%   +0.29%     
==========================================
  Files           7        7              
  Lines         125      126       +1     
  Branches       10       11       +1     
==========================================
+ Hits           78       79       +1     
  Misses         41       41              
  Partials        6        6
Impacted Files Coverage Δ
robots/settings.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ebe3d9...3258fa1. Read the comment docs.

@yakky yakky merged commit 7ab78c5 into jazzband:master Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant