Add dynamic loader class support #202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via `LOADER_CLASS` config option
Add support for dynamic loader classes
Also adds a test to ensure caching is working.
Fix name error
owais
reviewed
Aug 10, 2019
Collaborator
owais
left a comment
owais
left a comment
There was a problem hiding this comment.
Thanks. Looks good. Added some comments.
| try: | ||
| urlpatterns.append(url(r'^admin/', include(admin.site.urls))) | ||
| except ImproperlyConfigured: | ||
| urlpatterns.append(url(r'^admin/', admin.site.urls)) |
Collaborator
There was a problem hiding this comment.
Is this for Django backward compatibility? I'd suggest to import django, check the version and have an if -else clause based on the version to make it obvious for the reader.
| _assets = {} | ||
|
|
||
| def __init__(self, name='DEFAULT'): | ||
| def __init__(self, config, name='DEFAULT'): |
Collaborator
There was a problem hiding this comment.
may be remove the default param as we always explicitly pass the config now.
| django110: django>=1.10.0,<1.11.0 | ||
| django_jinja | ||
| django111: django>=1.11.0,<2.0 | ||
| django22: django>=2.2.0,<2.3 |
Collaborator
There was a problem hiding this comment.
We should also support 2.1 and 2.0 explicitly.
Collaborator
|
I suppose this is not needed anymore now that we've merged another PR that implemented custom load classes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drops support for older versions of Python/Django, and introduces support for newer ones. Those changes may or may not be acceptable here, but I wanted to open this for an example of the dynamic loader class support, which we're using to load the stats file via
staticfiles_storage.open().