Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort format controls to ensure consistent results #1098

Merged
merged 2 commits into from Apr 1, 2020

Conversation

richafrank
Copy link
Contributor

@richafrank richafrank commented Mar 31, 2020

Sort format controls when writing them to ensure consistent results

Fixes #1097

Changelog-friendly one-liner: Sort format controls to ensure consistent results

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #1098 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   99.42%   99.42%   -0.01%     
==========================================
  Files          34       34              
  Lines        2443     2441       -2     
  Branches      302      302              
==========================================
- Hits         2429     2427       -2     
  Misses          8        8              
  Partials        6        6              
Impacted Files Coverage Δ
piptools/utils.py 100.00% <ø> (ø)
piptools/writer.py 99.25% <100.00%> (ø)
tests/test_writer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692f6be...6a11740. Read the comment docs.

@atugushev atugushev added bug fix writer Related to results output writer component labels Apr 1, 2020
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev added this to the 5.0.0 milestone Apr 1, 2020
@atugushev atugushev merged commit 878fb31 into jazzband:master Apr 1, 2020
@atugushev
Copy link
Member

Thanks, @richafrank for fixing and @auvipy for reviewing this! 🙏

@richafrank richafrank deleted the consistent-format-controls branch April 1, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writer Related to results output writer component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-compile gives different ordered output of --no-binary flags each run
3 participants