Add pyproject.toml file#1643
Merged
ssbarnea merged 9 commits intojazzband:masterfrom Nov 17, 2022
Merged
Conversation
webknjaz
reviewed
Jun 25, 2022
ssbarnea
approved these changes
Nov 17, 2022
atugushev
approved these changes
Nov 17, 2022
Member
atugushev
left a comment
atugushev
left a comment
There was a problem hiding this comment.
LGTM. Maybe strip obvious comments?
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
ssbarnea
approved these changes
Nov 17, 2022
atugushev
added
enhancement
webknjaz
reviewed
Nov 18, 2022
| python setup.py --version | ||
| python setup.py sdist --format=gztar bdist_wheel | ||
| python -m build | ||
| twine check dist/* |
Member
There was a problem hiding this comment.
In fact adding strict would require fixing another bug, that is why I did not mention it during review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1642.
Addresses #1642
Adding a sparse
pyproject.tomlfile as replacement forsetup.pyAdding comments to
.github/workflows/release.ymlfor proposed build steps ifsetup.pyis usedContributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.