Skip to content

Generate hashes for all available candidates - #1723

Merged
atugushev merged 7 commits into
jazzband:masterfrom
neykov:hashes-from-multiple-locations
Nov 19, 2022
Merged

Generate hashes for all available candidates#1723
atugushev merged 7 commits into
jazzband:masterfrom
neykov:hashes-from-multiple-locations

Conversation

@neykov

@neykov neykov commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

Generate hashes covering the PyPi index as well as additional candidates available through an extra index of find-links. Currently if PyPi index is available the hashes will be limited to those available in it.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Fixes #1662

@neykov
neykov force-pushed the hashes-from-multiple-locations branch 2 times, most recently from 652f574 to 663100c Compare November 12, 2022 07:44
@ssbarnea ssbarnea added the bug Something is not working label Nov 13, 2022
@ssbarnea
ssbarnea requested a review from atugushev November 13, 2022 01:34
Comment thread tests/test_repository_pypi.py Outdated
Comment thread tests/test_cli_compile.py Outdated
@neykov
neykov force-pushed the hashes-from-multiple-locations branch 3 times, most recently from 6cd6261 to fbeae56 Compare November 15, 2022 10:30
@neykov
neykov requested a review from atugushev November 17, 2022 19:35
@neykov
neykov force-pushed the hashes-from-multiple-locations branch from 99ad0d2 to 3539891 Compare November 18, 2022 09:24
@neykov

neykov commented Nov 18, 2022

Copy link
Copy Markdown
Contributor Author

@atugushev wdyt about the current test coverage?
I've had a failing test on Python 3.11 so I added a couple of troubleshooting lines to get more details.

@atugushev

atugushev commented Nov 18, 2022

Copy link
Copy Markdown
Member

wdyt about the current test coverage?
I've had a failing test on Python 3.11 so I added a couple of troubleshooting lines to get more details.

$ python -VV
Python 3.11.0 (main, Nov  5 2022, 13:30:21) [Clang 14.0.0 (clang-1400.0.29.202)]

$ pip install  torch-scatter
Collecting torch-scatter
  Downloading torch_scatter-2.0.9.tar.gz (21 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/private/var/folders/l0/lnq1ghps5yqc4vkgszlcz92m0000gp/T/pip-install-atqd84a8/torch-scatter_16f8ceb7339c4e66b1b07d1d16db074c/setup.py", line 8, in <module>
          import torch
      ModuleNotFoundError: No module named 'torch'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

That's because it's been installed from sdists from PyPI (note "Downloading torch_scatter-2.0.9.tar.gz"), which has import torch in setup.py. Note, there are no wheels for Python 3.11 in https://data.pyg.org/whl/torch-1.13.0+cpu.html.

With others Python version works fine, because they've been installed from wheels from https://data.pyg.org/whl/torch-1.13.0+cpu.html

Comment thread piptools/repositories/pypi.py Outdated
@atugushev atugushev added the hashes Related to hashes generated via --generate-hashes label Nov 19, 2022
@atugushev atugushev added this to the 6.11.0 milestone Nov 19, 2022
neykov and others added 6 commits November 19, 2022 17:59
Generate hashes covering the PyPi index as well as additional candidates available through an extra index of find-links. Currently if PyPi index is available the hashes will be limited to those available in it.

[#pre-commit.ci] auto fixes from pre-commit.com hooks
[#pre-commit.ci] auto fixes from pre-commit.com hooks
@neykov
neykov force-pushed the hashes-from-multiple-locations branch from 0107f68 to b649d0a Compare November 19, 2022 15:59
@neykov

neykov commented Nov 19, 2022

Copy link
Copy Markdown
Contributor Author

That's looking better, thanks for the help on the test side @atugushev.

@atugushev atugushev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉 A few comments about docstrings:

Comment thread piptools/repositories/pypi.py Outdated
Comment thread piptools/repositories/pypi.py Outdated
@neykov
neykov force-pushed the hashes-from-multiple-locations branch from b649d0a to b01d481 Compare November 19, 2022 19:52
@atugushev
atugushev enabled auto-merge (squash) November 19, 2022 20:12
@atugushev
atugushev disabled auto-merge November 19, 2022 20:12
@atugushev
atugushev enabled auto-merge (squash) November 19, 2022 20:15
@atugushev
atugushev merged commit 5cb6d9e into jazzband:master Nov 19, 2022
@neykov
neykov deleted the hashes-from-multiple-locations branch November 20, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working hashes Related to hashes generated via --generate-hashes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

problems installing torch-geometric

3 participants