Support build isolation using setuptools/pyproject.toml requirement files#1727
Merged
Conversation
Pass --build-isolation/--no-build-isolation option to metadata builder when setuptools/pyproject.toml requirement file is used.
atugushev
marked this pull request as ready for review
November 13, 2022 11:20
setuptools/pyproject.toml requirement filessetuptools/pyproject.toml requirement files
ssbarnea
approved these changes
Nov 14, 2022
ssbarnea
enabled auto-merge (squash)
November 14, 2022 21:47
atugushev
disabled auto-merge
November 14, 2022 23:59
atugushev
enabled auto-merge (squash)
November 14, 2022 23:59
duoi
approved these changes
Nov 15, 2022
duoi
left a comment
Member
There was a problem hiding this comment.
LGTM -- can it be rebased against the latest changes?
There are some failures but it looks like the pipeline might just need to be re-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
--build-isolation/--no-build-isolationoption to metadata builder when setuptools/pyproject.toml requirement file is used.Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.