Skip to content

Support build isolation using setuptools/pyproject.toml requirement files#1727

Merged
atugushev merged 4 commits into
jazzband:masterfrom
atugushev:setup-build-isolation
Nov 15, 2022
Merged

Support build isolation using setuptools/pyproject.toml requirement files#1727
atugushev merged 4 commits into
jazzband:masterfrom
atugushev:setup-build-isolation

Conversation

@atugushev

@atugushev atugushev commented Nov 13, 2022

Copy link
Copy Markdown
Member

Pass --build-isolation/--no-build-isolation option to metadata builder when setuptools/pyproject.toml requirement file is used.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Pass --build-isolation/--no-build-isolation option to metadata builder
when setuptools/pyproject.toml requirement file is used.
@atugushev atugushev added enhancement Improvements to functionality setuptools Related to compiling requirements with `setuptools` build backend pep-517 Related to PEP-517 standard API pyproject.toml Related to pyproject.toml support labels Nov 13, 2022
@atugushev
atugushev marked this pull request as ready for review November 13, 2022 11:20
@atugushev atugushev changed the title Support build isolation in setuptools/pyproject.toml requirement files Support build isolation using setuptools/pyproject.toml requirement files Nov 13, 2022
@ssbarnea
ssbarnea enabled auto-merge (squash) November 14, 2022 21:47
@atugushev atugushev added this to the 6.11.0 milestone Nov 14, 2022
@atugushev
atugushev disabled auto-merge November 14, 2022 23:59
@atugushev
atugushev enabled auto-merge (squash) November 14, 2022 23:59

@duoi duoi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- can it be rebased against the latest changes?

There are some failures but it looks like the pipeline might just need to be re-run

@atugushev
atugushev merged commit 8447633 into jazzband:master Nov 15, 2022
@atugushev
atugushev deleted the setup-build-isolation branch November 15, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvements to functionality pep-517 Related to PEP-517 standard API pyproject.toml Related to pyproject.toml support setuptools Related to compiling requirements with `setuptools` build backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants