Filter out the user provided unsafe packages#1766
Merged
Merged
Conversation
Contributor
Author
|
Does unsafe_requirements in writer._iter_lines provide None as default value only for tests? Because reolver.unsafe_requirements is an empty set by default. |
Member
It looks like it does. |
Contributor
Author
|
Should I refactor unsafe_requirements and unsafe_packages without None in _iter_lines? |
Member
Feel free to 👍🏻 |
As tox v4 included some side-effects, that will restore the lost colors.
Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
atugushev
reviewed
Dec 11, 2022
auto-merge was automatically disabled
December 11, 2022 18:37
Head branch was pushed to by a user without write access
Contributor
Author
|
@atugushev could you enable auto-merge again, i pushed again |
ssbarnea
approved these changes
Dec 11, 2022
Member
|
Thanks @q0w for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1756
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.