New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANCHORLINKS not working #222

Closed
stevenemrick opened this Issue Jun 26, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@stevenemrick

stevenemrick commented Jun 26, 2015

hi - I upgraded to pegdown 1.5.0 and I'm on Jbake 2.4.0 now. In my jbake.properties file I want to use ANCHORLINKS in my markdown.extensions, as pegdown 1.5.0 now supports this. But it's not working. I need the functionality to create jump tags within a page. Does anyone know why this is not working? I also created a ticket on the pegdown site.

@uli-heller

This comment has been minimized.

Show comment
Hide comment
@uli-heller

uli-heller Jul 4, 2015

Contributor

I've tried to investigate a little bit about about ANCHORLINKS:

  • pegdown-1.5.0 has been released in Feb 2015
  • on its intro page, I don't find anything related to anchorlinks
  • within github, I can search for ANCHORLINKS and find some references
  • as mentioned by you, it has to show up within Extensions.java and it is there in the master branch
  • within 1.5.0, I find it, too, but it has a bad value 0x300 vs. 0x400
  • I guess we'll have to wait for pegdown-1.5.1, maybe it will work then
Contributor

uli-heller commented Jul 4, 2015

I've tried to investigate a little bit about about ANCHORLINKS:

  • pegdown-1.5.0 has been released in Feb 2015
  • on its intro page, I don't find anything related to anchorlinks
  • within github, I can search for ANCHORLINKS and find some references
  • as mentioned by you, it has to show up within Extensions.java and it is there in the master branch
  • within 1.5.0, I find it, too, but it has a bad value 0x300 vs. 0x400
  • I guess we'll have to wait for pegdown-1.5.1, maybe it will work then
@uli-heller

This comment has been minimized.

Show comment
Hide comment
@uli-heller

uli-heller Jul 10, 2015

Contributor

So, I made a few more tests:

  1. I recompiled jbake-2.4.0 using pegdown-1.5.0 instead of pegdown-1.4.2
  2. Within jbake.properties, I have this: markdown.extensions=ALL,-HARDWRAPS
  3. Then, I "baked" some sample pages

With standard 2.4.0 using pegdown-1.4.2, the outcome looks like this:

<h2>Titel</h2><p>Als Titel...

With the freshly compiled 2.4.0 using pegdown-1.5.0, the outcome looks like this:

<h2><a href="#titel" name="titel">Titel</a></h2><p>Als Titel...

So I think:

  • pegdown-1.5.0 allows you to use the anchorlinks when you specify "ALL" within your jbake.properties
  • pegdown-1.5.1 will probably allow you to use ANCHORLINKS within your jbake.properties
Contributor

uli-heller commented Jul 10, 2015

So, I made a few more tests:

  1. I recompiled jbake-2.4.0 using pegdown-1.5.0 instead of pegdown-1.4.2
  2. Within jbake.properties, I have this: markdown.extensions=ALL,-HARDWRAPS
  3. Then, I "baked" some sample pages

With standard 2.4.0 using pegdown-1.4.2, the outcome looks like this:

<h2>Titel</h2><p>Als Titel...

With the freshly compiled 2.4.0 using pegdown-1.5.0, the outcome looks like this:

<h2><a href="#titel" name="titel">Titel</a></h2><p>Als Titel...

So I think:

  • pegdown-1.5.0 allows you to use the anchorlinks when you specify "ALL" within your jbake.properties
  • pegdown-1.5.1 will probably allow you to use ANCHORLINKS within your jbake.properties
@stevenemrick

This comment has been minimized.

Show comment
Hide comment
@stevenemrick

stevenemrick Jul 10, 2015

Wow - I could have sworn I tried the 'ALL' solution and it didn't work, but of course it is now ;)
Thank you!!

stevenemrick commented Jul 10, 2015

Wow - I could have sworn I tried the 'ALL' solution and it didn't work, but of course it is now ;)
Thank you!!

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Aug 13, 2015

Member

Thanks for doing the investigation @uli-heller

If a new release of Pegdown is released soon I'll make sure to include it in the next release.

Member

jonbullock commented Aug 13, 2015

Thanks for doing the investigation @uli-heller

If a new release of Pegdown is released soon I'll make sure to include it in the next release.

@jonbullock jonbullock added this to the v2.5.0 milestone Aug 13, 2015

@jonbullock jonbullock closed this in 9d75eca Jul 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment