New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental rendering feature is broken in v2.4.0 #226

Closed
cloudtu opened this Issue Aug 14, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@cloudtu

cloudtu commented Aug 14, 2015

I add db.store=local in jbake.properties. It enable incremental rendering feature,but always render all pages every time. This feature is broken in v2.4.0.

first run

14:18:46.415 INFO  org.jbake.app.Oven - Baking has started...
14:18:46.438 INFO  org.jbake.app.Crawler - Processing [.\content\about.html]...  : new
14:18:46.443 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\first-post.html]...  : new
14:18:46.447 INFO  org.jbake.parser.AsciidoctorEngine - Initializing Asciidoctor engine...
14:18:48.998 INFO  org.jbake.parser.AsciidoctorEngine - Asciidoctor engine initialized.
14:18:49.106 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\fourth-post.adoc]...  : new
14:18:49.345 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\second-post.md]...  : new
14:18:49.378 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\third-post.adoc]...  : new
14:18:49.378 INFO  org.jbake.app.Oven - Content detected:
14:18:49.379 INFO  org.jbake.app.Oven - Parsed 1 files of type: page
14:18:49.380 INFO  org.jbake.app.Oven - Parsed 4 files of type: post
...etc
14:18:49.668 INFO  org.jbake.app.Oven - Baking finished!
14:18:49.670 INFO  org.jbake.app.Oven - Baked 5 items in 3256ms

second run

14:19:09.502 INFO  org.jbake.app.Oven - Baking has started...
14:19:09.530 INFO  org.jbake.app.Crawler - Processing [.\content\about.html]...  : new
14:19:09.540 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\first-post.html]...  : new
14:19:09.545 INFO  org.jbake.parser.AsciidoctorEngine - Initializing Asciidoctor engine...
14:19:12.100 INFO  org.jbake.parser.AsciidoctorEngine - Asciidoctor engine initialized.
14:19:12.217 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\fourth-post.adoc]...  : new
14:19:12.482 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\second-post.md]...  : new
14:19:12.518 INFO  org.jbake.app.Crawler - Processing [.\content\blog\2013\third-post.adoc]...  : new
14:19:12.518 INFO  org.jbake.app.Oven - Content detected:
14:19:12.519 INFO  org.jbake.app.Oven - Parsed 2 files of type: page
14:19:12.521 INFO  org.jbake.app.Oven - Parsed 8 files of type: post
...etc
14:19:12.833 INFO  org.jbake.app.Oven - Baking finished!
14:19:12.834 INFO  org.jbake.app.Oven - Baked 5 items in 3334ms

I found this feature work well in v2.3.2,but broken in v2.4.0. Please help to solve this bug, thanks a lot.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Aug 16, 2015

Member

Thanks for taking the time to raise this issue... I'll investigate and get back to you.

Member

jonbullock commented Aug 16, 2015

Thanks for taking the time to raise this issue... I'll investigate and get back to you.

@jonbullock jonbullock self-assigned this Aug 16, 2015

@jonbullock jonbullock added the bug label Aug 16, 2015

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Aug 16, 2015

Member

Ah the following line needs to be added to: https://github.com/jbake-org/jbake/blob/master/src/main/java/org/jbake/app/Crawler.java#L127

fileContents.put("sourceuri", uri);
Member

jonbullock commented Aug 16, 2015

Ah the following line needs to be added to: https://github.com/jbake-org/jbake/blob/master/src/main/java/org/jbake/app/Crawler.java#L127

fileContents.put("sourceuri", uri);

@jonbullock jonbullock added this to the v2.5.0 milestone Aug 16, 2015

jonbullock added a commit that referenced this issue Nov 19, 2015

Added watch mode - #183.
Fixed incremental builds - #226.

@jonbullock jonbullock closed this Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment