New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting asciidoctor.option.template_dirs in jbake.properties causes an error #252

Closed
mtolk opened this Issue Dec 9, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@mtolk

mtolk commented Dec 9, 2015

I'm using asciidoc document in JBake to generate my website.
I want to make some changes to the HTML asciidoctor generates so I wanted to use the template_dirs option.

Doing this gives an error:

An unexpected error occurred: (NoMethodError) asciidoctor: FAILED: : Failed to parse source,     undefined method `each' for "src/custom-asciidoctor-backends/erb/html5":String

I think I figured out what the problem is.
When you pass the option template_dirs asciidoctor expects a List.
JBake tries to guess the required object using the AsciidoctorEngine.guessTypeByContent() method,
but that method has no support for Lists, just String, Boolean and Number.

So the option template_dirs is passed to Asciidoctor as a String which causes the error inside asciidoctor.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Jan 14, 2016

Member

Thanks for raising this @mtolk we'll aim to fix this in the v2.5.0 release.

Member

jonbullock commented Jan 14, 2016

Thanks for raising this @mtolk we'll aim to fix this in the v2.5.0 release.

@jonbullock jonbullock added this to the v2.5.0 milestone Jan 14, 2016

@jonbullock jonbullock self-assigned this Jan 14, 2016

@jonbullock jonbullock closed this in 716e640 Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment