New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gemPath to be specified for the AsciidoctorEngine #267

Closed
aalmiray opened this Issue Feb 25, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@aalmiray
Contributor

aalmiray commented Feb 25, 2016

The current AsciidoctorEngine does not allow passing a gemPath option to the Asciidoctor.Factory.create(). This option is needed to enable additional functionality such as asciidoctorj-diagram.

@aalmiray

This comment has been minimized.

Show comment
Hide comment
@aalmiray

aalmiray Feb 26, 2016

Contributor

I can confirm with a quick "hack" that enabling gemPath and requires to be set on the Asciidoctor instance does allow diagrams to be rendered in a baked content. We'll have to wait for asciidoctor-1.6.0 to be released (and its companion asciidoctorj release) in order to avoid reflective calls to protected fields in Asciidoctor.

Contributor

aalmiray commented Feb 26, 2016

I can confirm with a quick "hack" that enabling gemPath and requires to be set on the Asciidoctor instance does allow diagrams to be rendered in a baked content. We'll have to wait for asciidoctor-1.6.0 to be released (and its companion asciidoctorj release) in order to avoid reflective calls to protected fields in Asciidoctor.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Feb 28, 2016

Member

👍

Member

jonbullock commented Feb 28, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment