New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on issue #181 #315

Closed
gilbertoca opened this Issue Nov 5, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@gilbertoca

gilbertoca commented Nov 5, 2016

After changing to the new version I've got the same behavior described in #181. I've not used the tag.sanitize option until now.

HTTP ERROR: 404

Problem accessing /tags/Estou%20lendo%20e%20voc%C3%AA.html. Reason:

    Not Found

Powered by Jetty:// 8.1.19.v20160209

With version 2.4.0:

sh ~/bin/jbake-2.4.0/bin/jbake -b src/main/jbake ./output 

09:58:12.452 INFO  org.jbake.app.Renderer - Rendering tags [./output/tags/Augusto Cury.html]... done!
09:58:12.455 INFO  org.jbake.app.Renderer - Rendering tags [./output/tags/Proteção.html]... done!
09:58:12.460 INFO  org.jbake.app.Renderer - Rendering tags [./output/tags/Modelagem.html]... done!
09:58:12.463 INFO  org.jbake.app.Renderer - Rendering tags [./output/tags/Ciência da Computação.html]... done!
09:58:12.467 INFO  org.jbake.app.Renderer - Rendering tags [./output/tags/Apache Click.html]... done!
09:58:12.470 INFO  org.jbake.app.Renderer - Rendering tags [./output/tags/Chromium.html]... done!

produces the correct output.
With version 2.5.0:

rm -rf output/
 sh ~/bin/jbake-2.5.0/bin/jbake -b src/main/jbake ./output  
JBake v2.5.0 (2016-10-07 20:26:22PM) [http://jbake.org]

10:02:42.945 INFO  org.jbake.app.Renderer - Rendering tag [./output/tags/Augusto-Cury.html]...done!
10:02:42.955 INFO  org.jbake.app.Renderer - Rendering tag [./output/tags/Proteção.html]...done!
10:02:42.974 INFO  org.jbake.app.Renderer - Rendering tag [./output/tags/Modelagem.html]...done!
10:02:42.992 INFO  org.jbake.app.Renderer - Rendering tag [./output/tags/Ciência-da-Computação.html]...done!
10:02:42.995 INFO  org.jbake.app.Renderer - Rendering tag [./output/tags/Apache-Click.html]...done!
10:02:43.001 INFO  org.jbake.app.Renderer - Rendering tag [./output/tags/Chromium.html]...done!

produces the output with hyphen, so breaking the blog site links. Adding the tag.sanitize=true option it works appropriately.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Nov 13, 2016

Member

Hi Gilberto, just to confirm I've understood correctly. The behaviour you experienced in 2.4.0 was that the tag values were not sanitized (i.e. spaces replaced with hyphens) by default but in 2.5.0 the tag values have been sanitized by default. Is this correct?

Member

jonbullock commented Nov 13, 2016

Hi Gilberto, just to confirm I've understood correctly. The behaviour you experienced in 2.4.0 was that the tag values were not sanitized (i.e. spaces replaced with hyphens) by default but in 2.5.0 the tag values have been sanitized by default. Is this correct?

@gilbertoca

This comment has been minimized.

Show comment
Hide comment
@gilbertoca

gilbertoca Nov 14, 2016

Yes, you've got it!
The tag files come with hyphens, but the content not.
Putting tag.sanitize=true make both with hyphens.

Yes, you've got it!
The tag files come with hyphens, but the content not.
Putting tag.sanitize=true make both with hyphens.

@jonbullock jonbullock added this to the v2.5.1 milestone Nov 16, 2016

@jonbullock jonbullock self-assigned this Nov 16, 2016

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Nov 16, 2016

Member

OK thanks for raising this, I'll investigate and see what's changed.

Member

jonbullock commented Nov 16, 2016

OK thanks for raising this, I'll investigate and see what's changed.

@jonbullock jonbullock added the bug label Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment