New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary refactoring #135

Merged
merged 6 commits into from Nov 18, 2015

Conversation

Projects
None yet
3 participants
@Riduidel

Riduidel commented Sep 2, 2014

I need to separate a little markup engine from the crawler code in order to insert jpeg engine into.
This change don't seems to break anything, and is only code move.

Riduidel added some commits Sep 2, 2014

Riduidel
Loading DocumentTypes without loading engines can lead to some bugs,
 such as an incorrect schema in OrientDB : only default document types are visible, whereas all types should be.
Riduidel
Extracted an interface over MarkupEngine
To be able to process images in a correct fashion, markup engine can't be the base abstraction as it requires splitting the file as lines, which jpeg images have not.
Riduidel
Seems like that low-level interface was missing in that branch.
It will allow image gallery generator to not read the lines of image file.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 4, 2014

Coverage Status

Coverage increased (+0.35%) when pulling 0cf49ae on Riduidel:preliminary-refactoring into 7aaaaaa on jbake-org:master.

coveralls commented Sep 4, 2014

Coverage Status

Coverage increased (+0.35%) when pulling 0cf49ae on Riduidel:preliminary-refactoring into 7aaaaaa on jbake-org:master.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Sep 21, 2014

Member

As soon as I'm back at home I'll review the changes properly.

Member

jonbullock commented Sep 21, 2014

As soon as I'm back at home I'll review the changes properly.

@jonbullock jonbullock added this to the v2.5.0 milestone May 13, 2015

@jonbullock jonbullock self-assigned this May 13, 2015

@jonbullock jonbullock merged commit 0cf49ae into jbake-org:master Nov 18, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

jonbullock added a commit that referenced this pull request Nov 18, 2015

jonbullock added a commit that referenced this pull request Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment