Extracted various rendering modes to allow their customization #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here, the goal is clear : by creating a list of rendering modes (that are in fact extracted from the main oven), I will later be able to add new rendering modes, which will be especially useful to implement "by date" archvies, or "by place", beside the usual tags.
added 3 commits
October 21, 2014 16:54
The first step is to highlight common structure by putting all constants in one common class. This common class will soon be transformed into something smarter (I think)
…models. Goals of this operation are multiple : - define an interface I could use for Dates hierarchies extraction - make code simpler to understand, as there is no more any duplication - made code extensible through ModelExtractors.properties file which can allow anyone to add one more model extractor simply by adding it to this configuration file (or any other loadable by JBake classloader) This however triggers a new issue : there are now 3 or 4 files using loading mechanism defined by Cédric Champeau. Maybe it could be time to ... rationalize that a little, no ?
…-request-for-extracted-rendering-tools
This allows as immediate benefit more simple code in Renderer. And will provide when dates rendering will be real some huge advantages by simplifying the adding of renderDatesByYear, renderDatesByMonth, ...
|
Thanks for this contribution, I'll look to get this merged for the v3.0.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, the goal is clear : by creating a list of rendering modes (that are in fact extracted from the main oven), I will later be able to add new rendering modes, which will be especially useful to implement "by date" archvies, or "by place", beside the usual tags.