New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted various rendering modes to allow their customization #138

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Riduidel

Riduidel commented Sep 8, 2014

Here, the goal is clear : by creating a list of rendering modes (that are in fact extracted from the main oven), I will later be able to add new rendering modes, which will be especially useful to implement "by date" archvies, or "by place", beside the usual tags.

Riduidel
Extracted various rendering modes to allow their customization
Here, the goal is clear : by creating a list of rendering modes (that are in fact extracted from the main oven), I will later be able to add new rendering modes, which will be especially useful to implement "by date" archvies,  or "by place", beside the usual tags.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 8, 2014

Coverage Status

Coverage decreased (-1.67%) when pulling cbf350a on Riduidel:pull-request-for-extracted-rendering-tools into 7aaaaaa on jbake-org:master.

coveralls commented Sep 8, 2014

Coverage Status

Coverage decreased (-1.67%) when pulling cbf350a on Riduidel:pull-request-for-extracted-rendering-tools into 7aaaaaa on jbake-org:master.

Riduidel added some commits Oct 21, 2014

Riduidel
Starting separation of model keys for various rendering engines
The first step is to highlight common structure by putting all constants in one common class.
This common class will soon be transformed into something smarter (I think)
Riduidel
Moved all model extraction code outside of specific template engines …
…models.

Goals of this operation are multiple :
 - define an interface I could use for Dates hierarchies extraction
 - make code simpler to understand, as there is no more any duplication
 - made code extensible through ModelExtractors.properties file which can allow anyone to add one more model extractor simply by adding it to this configuration file (or any other loadable by JBake classloader)

This however triggers a new issue : there are now 3 or 4 files using loading mechanism defined by Cédric Champeau. Maybe it could be time to ... rationalize that a little, no ?
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 23, 2014

Coverage Status

Coverage decreased (-1.59%) when pulling 3e6c742 on Riduidel:pull-request-for-extracted-rendering-tools into f9b81eb on jbake-org:master.

coveralls commented Oct 23, 2014

Coverage Status

Coverage decreased (-1.59%) when pulling 3e6c742 on Riduidel:pull-request-for-extracted-rendering-tools into f9b81eb on jbake-org:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 23, 2014

Coverage Status

Coverage decreased (-1.82%) when pulling 3e6c742 on Riduidel:pull-request-for-extracted-rendering-tools into f9b81eb on jbake-org:master.

coveralls commented Oct 23, 2014

Coverage Status

Coverage decreased (-1.82%) when pulling 3e6c742 on Riduidel:pull-request-for-extracted-rendering-tools into f9b81eb on jbake-org:master.

Riduidel
Refactored Renderer to provide smaller code
This allows as immediate benefit more simple code in Renderer. And will provide when dates rendering will be real some huge advantages by simplifying the adding of renderDatesByYear, renderDatesByMonth, ...
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 27, 2014

Coverage Status

Coverage decreased (-1.77%) when pulling b1cedd9 on Riduidel:pull-request-for-extracted-rendering-tools into f9b81eb on jbake-org:master.

coveralls commented Oct 27, 2014

Coverage Status

Coverage decreased (-1.77%) when pulling b1cedd9 on Riduidel:pull-request-for-extracted-rendering-tools into f9b81eb on jbake-org:master.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Nov 2, 2014

Member

Thanks for this contribution, I'll look to get this merged for the v3.0.0 release.

Member

jonbullock commented Nov 2, 2014

Thanks for this contribution, I'll look to get this merged for the v3.0.0 release.

@jonbullock jonbullock added this to the v3.0.0 milestone Nov 2, 2014

@jonbullock jonbullock self-assigned this Nov 2, 2014

@jonbullock jonbullock modified the milestones: v3.0.0, v2.5.0 May 13, 2015

jonbullock added a commit that referenced this pull request Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment