New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and aggregate rendering testing #175

Merged
merged 2 commits into from Nov 18, 2015

Conversation

Projects
None yet
3 participants
@jasondlee
Contributor

jasondlee commented Feb 11, 2015

In getting ready to implement pagination, I felt I needed to test the Freemarker template engine, as that's what I intended to use (so I want to make sure it works ;). As I was working on it, I realized all of the tests for the template engines were the same, so I refactored the code so that they share as much as possible. There are some minor differences in the resulting HTML (that might warrant some investigation) thus the code in the ctors, but I didn't see that as a show stopper for integrating the current state of the refactoring.

Create an abstract base test
Extend the base class for each template engine

jasondlee added some commits Feb 11, 2015

Simplify rendering testing
Create an abstract base test
Extend the base class for each template engine
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 12, 2015

Coverage Status

Coverage increased (+0.22%) to 64.26% when pulling e817a8b on jasondlee:testing into 31adbaf on jbake-org:master.

coveralls commented Feb 12, 2015

Coverage Status

Coverage increased (+0.22%) to 64.26% when pulling e817a8b on jasondlee:testing into 31adbaf on jbake-org:master.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Feb 13, 2015

Member

Thanks again Jason for the contribution. I should have some time next week to review this.

Member

jonbullock commented Feb 13, 2015

Thanks again Jason for the contribution. I should have some time next week to review this.

@jonbullock jonbullock added this to the v2.5.0 milestone May 14, 2015

@jonbullock jonbullock merged commit e817a8b into jbake-org:master Nov 18, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

jonbullock added a commit that referenced this pull request Nov 18, 2015

jonbullock added a commit that referenced this pull request Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment