New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced Groovy MarkupTemplateEngine #185

Merged
merged 7 commits into from Nov 18, 2015

Conversation

Projects
None yet
5 participants
@ancho
Member

ancho commented Mar 13, 2015

The Template Engine is registered for template files with suffix '.tpl'
It is basically a clone of GroovyTemplateEngine using the Groovy MarkupTemplateEngine.

Because there are refactoring pull-requests out there, I skipped refactoring those two Engines for now.

To unify the Renderer Tests for different TemplateEngines there is a new Spock-Test called RendererSpec.

ancho added some commits Mar 12, 2015

added Groovy MarkupTemplate Engine
The Template Engine is registered for template files with suffix '.tpl'
It is basically a clone of GroovyTemplateEngine using the Groovy MarkupTemplateEngine.

Because there are refactoring pull-requests out there, I skipped refactoring those two Engines for now.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 13, 2015

Coverage Status

Coverage increased (+1.02%) to 65.06% when pulling 751c7bb on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

coveralls commented Mar 13, 2015

Coverage Status

Coverage increased (+1.02%) to 65.06% when pulling 751c7bb on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 13, 2015

Coverage Status

Coverage increased (+1.02%) to 65.06% when pulling 751c7bb on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

coveralls commented Mar 13, 2015

Coverage Status

Coverage increased (+1.02%) to 65.06% when pulling 751c7bb on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 13, 2015

Coverage Status

Coverage increased (+1.73%) to 65.77% when pulling b8cebe5 on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

coveralls commented Mar 13, 2015

Coverage Status

Coverage increased (+1.73%) to 65.77% when pulling b8cebe5 on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

@melix

This comment has been minimized.

Show comment
Hide comment
@melix

melix Mar 13, 2015

You should probably put the template engine as a field, rather than recreating it each time (and the MTE does include a cache already).

You should probably put the template engine as a field, rather than recreating it each time (and the MTE does include a cache already).

@ancho

This comment has been minimized.

Show comment
Hide comment
@ancho

ancho Mar 13, 2015

Member

thanks @melix for the clue. I didn't dive that deep but I'll reconsider it.

Member

ancho commented Mar 13, 2015

thanks @melix for the clue. I didn't dive that deep but I'll reconsider it.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 13, 2015

Coverage Status

Coverage increased (+4.08%) to 68.11% when pulling 564a1a5 on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

coveralls commented Mar 13, 2015

Coverage Status

Coverage increased (+4.08%) to 68.11% when pulling 564a1a5 on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 13, 2015

Coverage Status

Coverage increased (+3.86%) to 67.9% when pulling 74e259b on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

coveralls commented Mar 13, 2015

Coverage Status

Coverage increased (+3.86%) to 67.9% when pulling 74e259b on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 13, 2015

Coverage Status

Coverage increased (+3.86%) to 67.9% when pulling b58f43d on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

coveralls commented Mar 13, 2015

Coverage Status

Coverage increased (+3.86%) to 67.9% when pulling b58f43d on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 13, 2015

Coverage Status

Coverage increased (+3.79%) to 67.83% when pulling 2bc97b6 on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

coveralls commented Mar 13, 2015

Coverage Status

Coverage increased (+3.79%) to 67.83% when pulling 2bc97b6 on ancho:feature/GroovyMarkupTemplateEngine into 31adbaf on jbake-org:master.

@jonbullock jonbullock self-assigned this Mar 24, 2015

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Mar 24, 2015

Member

Thanks so much, I've wanted to add support for this for a while now!

Member

jonbullock commented Mar 24, 2015

Thanks so much, I've wanted to add support for this for a while now!

@melix

This comment has been minimized.

Show comment
Hide comment
@melix

melix Mar 24, 2015

Contributor

👍

Contributor

melix commented Mar 24, 2015

👍

@ancho

This comment has been minimized.

Show comment
Hide comment
@ancho

ancho Mar 26, 2015

Member

You're welcome ;)
I'm working on an example-project. I'll let you know as soon as I have finished.

Member

ancho commented Mar 26, 2015

You're welcome ;)
I'm working on an example-project. I'll let you know as soon as I have finished.

@ancho

This comment has been minimized.

Show comment
Hide comment
@ancho

ancho May 3, 2015

Member

Hi. It's been a while, but I finally finished an example project using Groovy Markup Templates.
Have a look at https://github.com/ancho/jbake-example-project-groovy

To test the distribution I added a feature branch too.
See https://github.com/ancho/jbake/tree/feature/example-project-groovy-mte

Member

ancho commented May 3, 2015

Hi. It's been a while, but I finally finished an example project using Groovy Markup Templates.
Have a look at https://github.com/ancho/jbake-example-project-groovy

To test the distribution I added a feature branch too.
See https://github.com/ancho/jbake/tree/feature/example-project-groovy-mte

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock May 5, 2015

Member

Thanks again Frank, I've got some spare time again now so I'll make sure to review this as soon as possible and then work out when we can get it into a release.

Member

jonbullock commented May 5, 2015

Thanks again Frank, I've got some spare time again now so I'll make sure to review this as soon as possible and then work out when we can get it into a release.

@jonbullock jonbullock added this to the v2.5.0 milestone Jun 3, 2015

@danhyun

This comment has been minimized.

Show comment
Hide comment
@danhyun

danhyun commented Jun 21, 2015

👍

@jonbullock jonbullock merged commit 2bc97b6 into jbake-org:master Nov 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonbullock added a commit that referenced this pull request Nov 18, 2015

jonbullock added a commit that referenced this pull request Nov 18, 2015

@ancho

This comment has been minimized.

Show comment
Hide comment
@ancho

ancho Nov 19, 2015

Member

+1

Member

ancho commented Nov 19, 2015

+1

@ancho ancho deleted the ancho:feature/GroovyMarkupTemplateEngine branch May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment