New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination #186

Merged
merged 11 commits into from Nov 18, 2015

Conversation

Projects
None yet
4 participants
@jasondlee
Contributor

jasondlee commented Mar 18, 2015

This seems to do the trick. I'm currently using it to publish my blog. :)

I added a test for Freemarker in this is as well. While not directly related, certainly helpful. I think the template engine tests can be refactored further to reduce the amount of duplication, but that's a task for another branch.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 18, 2015

Coverage Status

Coverage increased (+0.11%) to 64.14% when pulling 7001d20 on jasondlee:pagination into 31adbaf on jbake-org:master.

coveralls commented Mar 18, 2015

Coverage Status

Coverage increased (+0.11%) to 64.14% when pulling 7001d20 on jasondlee:pagination into 31adbaf on jbake-org:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 19, 2015

Coverage Status

Coverage increased (+0.21%) to 64.24% when pulling 7104276 on jasondlee:pagination into 31adbaf on jbake-org:master.

coveralls commented Mar 19, 2015

Coverage Status

Coverage increased (+0.21%) to 64.24% when pulling 7104276 on jasondlee:pagination into 31adbaf on jbake-org:master.

@jonbullock jonbullock self-assigned this Mar 24, 2015

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Mar 24, 2015

Member

Excellent! I'll be reviewing all the outstanding PR's soon and getting them merged or scheduled to be merged.

Thanks again.

Member

jonbullock commented Mar 24, 2015

Excellent! I'll be reviewing all the outstanding PR's soon and getting them merged or scheduled to be merged.

Thanks again.

@jasondlee

This comment has been minimized.

Show comment
Hide comment
@jasondlee

jasondlee Apr 24, 2015

Contributor

Any update on this? :)

Contributor

jasondlee commented Apr 24, 2015

Any update on this? :)

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock May 5, 2015

Member

Apologies Jason I got snowed under, so in answer to your question, no :(

But I've got some spare time again so I'll get back onto it soon.

Member

jonbullock commented May 5, 2015

Apologies Jason I got snowed under, so in answer to your question, no :(

But I've got some spare time again so I'll get back onto it soon.

@jasondlee

This comment has been minimized.

Show comment
Hide comment
@jasondlee

jasondlee May 5, 2015

Contributor

No worries. Just checking in. :)

On 5/5/15 7:13 AM, Jonathan Bullock wrote:

Apologies Jason I got snowed under, so in answer to your question, no :(

But I've got some spare time again so I'll get back onto it soon.


Reply to this email directly or view it on GitHub
#186 (comment).

Jason Lee
http://cubtracker.com
http://blogs.steeplesoft.com
http://twitter.com/jasondlee
http://blogs.steeplesoft.com/+
http://blogs.steeplesoft.com/in

Contributor

jasondlee commented May 5, 2015

No worries. Just checking in. :)

On 5/5/15 7:13 AM, Jonathan Bullock wrote:

Apologies Jason I got snowed under, so in answer to your question, no :(

But I've got some spare time again so I'll get back onto it soon.


Reply to this email directly or view it on GitHub
#186 (comment).

Jason Lee
http://cubtracker.com
http://blogs.steeplesoft.com
http://twitter.com/jasondlee
http://blogs.steeplesoft.com/+
http://blogs.steeplesoft.com/in

@jonbullock jonbullock added this to the v2.5.0 milestone May 14, 2015

jasondlee added some commits Jan 23, 2015

Move template keys to constants
Fix some missing javadoc tags
Create test for Freemarker rendering
Add assets for FM test
Remove unused import in ThymeleafRenderTest
Add keys to support navigation
Update Renderer.renderIndex to be pagination-aware
Update ContentStore to ne pagination-aware
Add pagination test
Fix API call in test
Remove pagination APIs from properties file
Fix previous page file name on second page
Make sure prev/next filenames aren't available in the model when those
pages don't exist
@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Jun 7, 2015

Member

Started to merge this in and noticed you added the 'freemarkerTemplates' folder. Is this a copy of the existing 'templates' folder? Or a new set of templates specific to this PR?

Member

jonbullock commented Jun 7, 2015

Started to merge this in and noticed you added the 'freemarkerTemplates' folder. Is this a copy of the existing 'templates' folder? Or a new set of templates specific to this PR?

@uli-heller

This comment has been minimized.

Show comment
Hide comment
@uli-heller

uli-heller Jun 12, 2015

Contributor

If you need help on GSP templates, I'm volunteering in helping onr this. I like the paging approach, I'm using GSP templates and I do have a little bit of free time for the next weeks.

Contributor

uli-heller commented Jun 12, 2015

If you need help on GSP templates, I'm volunteering in helping onr this. I like the paging approach, I'm using GSP templates and I do have a little bit of free time for the next weeks.

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Jun 13, 2015

Member

Thanks for the offer... I'm in the middle of merging in all the outstanding PRs for 2.5.0 including this one... so it'll take a bit of time before I commit back. What kind of help where you thinking of?

Member

jonbullock commented Jun 13, 2015

Thanks for the offer... I'm in the middle of merging in all the outstanding PRs for 2.5.0 including this one... so it'll take a bit of time before I commit back. What kind of help where you thinking of?

@uli-heller

This comment has been minimized.

Show comment
Hide comment
@uli-heller

uli-heller Jun 15, 2015

Contributor

Looking at the patch, I see some changes to the FTL templates. I think I could "port" these changes to the GSP templates, or test the patches using GSP templates, or fix some bugs within the templates and within the engines (at work, I'm a java developer).

Contributor

uli-heller commented Jun 15, 2015

Looking at the patch, I see some changes to the FTL templates. I think I could "port" these changes to the GSP templates, or test the patches using GSP templates, or fix some bugs within the templates and within the engines (at work, I'm a java developer).

@jasondlee

This comment has been minimized.

Show comment
Hide comment
@jasondlee

jasondlee Jun 25, 2015

Contributor

It's been a while, but, iirc, those are new files specifically for the
FreemarkerRendererTest added in this PR.

On 6/7/15 3:50 PM, Jonathan Bullock wrote:

Started to merge this in and noticed you added the
'freemarkerTemplates' folder. Is this a copy of the existing
'templates' folder? Or a new set of templates specific to this PR?


Reply to this email directly or view it on GitHub
#186 (comment).

Jason Lee
http://cubtracker.com
http://blogs.steeplesoft.com
http://twitter.com/jasondlee
http://blogs.steeplesoft.com/+
http://blogs.steeplesoft.com/in

Contributor

jasondlee commented Jun 25, 2015

It's been a while, but, iirc, those are new files specifically for the
FreemarkerRendererTest added in this PR.

On 6/7/15 3:50 PM, Jonathan Bullock wrote:

Started to merge this in and noticed you added the
'freemarkerTemplates' folder. Is this a copy of the existing
'templates' folder? Or a new set of templates specific to this PR?


Reply to this email directly or view it on GitHub
#186 (comment).

Jason Lee
http://cubtracker.com
http://blogs.steeplesoft.com
http://twitter.com/jasondlee
http://blogs.steeplesoft.com/+
http://blogs.steeplesoft.com/in

@jonbullock

This comment has been minimized.

Show comment
Hide comment
@jonbullock

jonbullock Aug 13, 2015

Member

Thanks Jason, I haven't forgotten about this, I did start to merge this in manually and started a list of clean up jobs for after the merge is complete. However, my recent new arrival has meant I've just had no spare time to carry on with it, hopefully soon I'll get chance to finish off the merge.

Member

jonbullock commented Aug 13, 2015

Thanks Jason, I haven't forgotten about this, I did start to merge this in manually and started a list of clean up jobs for after the merge is complete. However, my recent new arrival has meant I've just had no spare time to carry on with it, hopefully soon I'll get chance to finish off the merge.

@jonbullock jonbullock merged commit f458ffa into jbake-org:master Nov 18, 2015

jonbullock added a commit that referenced this pull request Nov 18, 2015

jonbullock added a commit that referenced this pull request Nov 18, 2015

This was referenced Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment